Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidance for commit message regex #29

Open
JayBazuzi opened this issue Sep 22, 2021 · 2 comments
Open

Guidance for commit message regex #29

JayBazuzi opened this issue Sep 22, 2021 · 2 comments

Comments

@JayBazuzi
Copy link
Collaborator

In GitLab under Settings -> Repository -> Push Rules you can set Require expression in commit messages. I assume GitHub has a similar feature.

A regex for ACN would need to be permissive enough to allow local extensions but require the extension.

Here's the regex I'm currently using: ^(([[:lower:]] )|([[:upper:]] )|([[:upper:]]!! )|([[:upper:]]\*\* ))|(\*\*\*).

When we add this guidance we could use CI to test it. Here are some test cases + questions:

image

@arlobelshee
Copy link
Contributor

I like making a suggestion that people include a push rule.

I think v2 ( #43 as the first attempt ) should make that easier.

@JayBazuzi
Copy link
Collaborator Author

Cool. Once v2 settles and ships, I plan to send a PR with the regex guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants