Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deprecation label to redoc-cli #2172

Merged
merged 11 commits into from
Mar 6, 2023

Conversation

AlexVarchuk
Copy link
Collaborator

@AlexVarchuk AlexVarchuk commented Sep 19, 2022

What/Why/How?

We deprecate redoc-cli and move our focus to Redoc.
Instead of redoc-cli you can use @redocly/cli.

redoc-cli serve <spec> -> @redocly/cli preview-docs <spec>
redoc-cli bundle/build <spec> -> @redocly/cli build-docs <spec>

remove update-notifier. Fixes #2185

Reference

Testing

Screenshots (optional)

Screenshot 2022-09-19 at 18 26 08

Screenshot 2022-09-19 at 18 47 52

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@AlexVarchuk AlexVarchuk requested a review from a team as a code owner September 19, 2022 15:26
@AlexVarchuk AlexVarchuk self-assigned this Sep 19, 2022
@AlexVarchuk AlexVarchuk requested review from Oprysk and RomanHotsiy and removed request for a team September 19, 2022 15:26
cli/README.md Outdated Show resolved Hide resolved
cli/index.ts Outdated Show resolved Hide resolved
cli/index.ts Outdated Show resolved Hide resolved
AlexVarchuk and others added 3 commits September 27, 2022 11:21
Co-authored-by: Adam Altman <[email protected]>
Co-authored-by: Adam Altman <[email protected]>
Co-authored-by: Adam Altman <[email protected]>
@ragaskar
Copy link

ragaskar commented Feb 8, 2023

fwiw, I found this ticket while trying to figure out how to address the recent CVEs that affect latest redoc-cli.

The instructions seem incorrect. Calling @redocly/cli results in no such file or directory: @redocly/cli. It looks like the cli bin is now just called redocly? Maybe obvious to others, but having the correct suggestion would've saved me ten minutes.

cli/README.md Outdated Show resolved Hide resolved
cli/index.ts Outdated Show resolved Hide resolved
cli/index.ts Outdated Show resolved Hide resolved
@AlexVarchuk AlexVarchuk requested a review from adamaltman March 6, 2023 09:44
@AlexVarchuk AlexVarchuk merged commit 2ae7e08 into main Mar 6, 2023
@AlexVarchuk AlexVarchuk deleted the feat/add-deprecation-label-to-redoc-cli branch March 6, 2023 12:36
ckoegel pushed a commit to Bandwidth/redoc that referenced this pull request Jun 6, 2023
ckoegel added a commit to Bandwidth/redoc that referenced this pull request Jun 6, 2023
ckoegel added a commit to Bandwidth/redoc that referenced this pull request Dec 3, 2024
ckoegel pushed a commit to Bandwidth/redoc that referenced this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot Issue CVE-2022-33987 at [email protected]
4 participants