Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: merge reference for openapi 3.1 #2063

Merged
merged 1 commit into from
Jul 5, 2022
Merged

Conversation

AlexVarchuk
Copy link
Collaborator

What/Why/How?

we lost sibling functionality in version 2.0.0-rc.57-58. This PR fix it.
fix #2042

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

@@ -173,7 +173,7 @@ export class OpenAPIParser {
keys.some(k => k !== 'description' && k !== 'title' && k !== 'externalDocs')
) {
return {
allOf: [rest, resolved],
allOf: [resolved, rest],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it related to our recent changes in all of merging?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@AlexVarchuk AlexVarchuk merged commit 87541e4 into master Jul 5, 2022
@AlexVarchuk AlexVarchuk deleted the fix/merge-refs-for-3-1 branch July 5, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Siblings of $ref do not override the referenced object
2 participants