fix: remove dropdown-aria and use native select #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexVarchuk
force-pushed
the
fix/dropdown-select
branch
from
037ba21
to
a4fc82d
Compare
Oprysk
approved these changes
Mar 31, 2022
|
Checked on Windows 10 (Chrome v98, Microsoft Edge v100) |
AlexVarchuk
force-pushed
the
fix/dropdown-select
branch
from
a4fc82d
to
bcf4d4f
Compare
anastasiia-developer
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Remove dropdown-aria lib and use native select. We have too many issues with this dropdown. It should fixed it.
fixes #1691
fixes #1463
fixes #913
fixes #713
fixes #451
Reference
Testing
Screenshots (optional)
Before
After
Check yourself