Merge branch 'VecSim' of github.com:Avital-Fine/redisearch-go into VecSim

Avital-Fine · Avital-Fine · commit 5256331c8ce1 · 2022-04-07T15:12:41.000+03:00
diff --git a/redisearch/query.go b/redisearch/query.go
@@ -1,6 +1,7 @@
 package redisearch
 
 import (
+	"fmt"
 	"math"
 
 	"github.com/gomodule/redigo/redis"
@@ -252,7 +253,7 @@ func appendNumArgs(num float64, exclude bool, args redis.Args) redis.Args {
 	}
 
 	if exclude {
-		return append(args, "(", num)
+		return append(args, fmt.Sprint("(", num))
 	}
 	return append(args, num)
 }
diff --git a/redisearch/query_test.go b/redisearch/query_test.go
@@ -152,7 +152,7 @@ func Test_appendNumArgs(t *testing.T) {
 		want redis.Args
 	}{
 		{"1 arg", args{1.0, false, redis.Args{}}, redis.Args{1.0}},
-		{"1 excluded arg", args{1.0, true, redis.Args{}}, redis.Args{"(", 1.0}},
+		{"2.54 excluded arg", args{2.54, true, redis.Args{}}, redis.Args{"(2.54"}},
 		{"+inf", args{math.Inf(1), false, redis.Args{}}, redis.Args{"+inf"}},
 		{"+inf", args{math.Inf(-1), false, redis.Args{}}, redis.Args{"-inf"}},
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package redisearch`
`2`	`2`
`3`	`3`	`import (`
	`4`	`+ "fmt"`
`4`	`5`	`"math"`
`5`	`6`
`6`	`7`	`"github.com/gomodule/redigo/redis"`
`@@ -252,7 +253,7 @@ func appendNumArgs(num float64, exclude bool, args redis.Args) redis.Args {`
`252`	`253`	`}`
`253`	`254`
`254`	`255`	`if exclude {`
`255`		`- return append(args, "(", num)`
	`256`	`+ return append(args, fmt.Sprint("(", num))`
`256`	`257`	`}`
`257`	`258`	`return append(args, num)`
`258`	`259`	`}`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ func Test_appendNumArgs(t *testing.T) {`
`152`	`152`	`want redis.Args`
`153`	`153`	`}{`
`154`	`154`	`{"1 arg", args{1.0, false, redis.Args{}}, redis.Args{1.0}},`
`155`		`- {"1 excluded arg", args{1.0, true, redis.Args{}}, redis.Args{"(", 1.0}},`
	`155`	`+ {"2.54 excluded arg", args{2.54, true, redis.Args{}}, redis.Args{"(2.54"}},`
`156`	`156`	`{"+inf", args{math.Inf(1), false, redis.Args{}}, redis.Args{"+inf"}},`
`157`	`157`	`{"+inf", args{math.Inf(-1), false, redis.Args{}}, redis.Args{"-inf"}},`
`158`	`158`	`}`