Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workloads): add stack item to the button #667

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Fewwy
Copy link
Collaborator

@Fewwy Fewwy commented Jan 29, 2024

image

Without using stack item the "View all objects" button was clickable on the whole width of the row.

How to test:
remove stack item and you will be able to click view all object button anywhere in the row

@Fewwy Fewwy requested a review from a team as a code owner January 29, 2024 14:58
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6aa1406) 8.08% compared to head (917ca9e) 8.04%.
Report is 3 commits behind head on master.

Files Patch % Lines
...ts/ExpandedRulesDetails.js/ExpandedRulesDetails.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #667      +/-   ##
=========================================
- Coverage    8.08%   8.04%   -0.05%     
=========================================
  Files          67      67              
  Lines        3450    3469      +19     
  Branches      783     787       +4     
=========================================
  Hits          279     279              
- Misses       3171    3190      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fewwy Fewwy merged commit 590704f into RedHatInsights:master Jan 30, 2024
2 checks passed
@gkarat
Copy link
Collaborator

gkarat commented Jan 30, 2024

🎉 This PR is included in version 1.37.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants