Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RHINENG-7723): workload replace API endpoints with mock data #660

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

AsToNlele
Copy link
Contributor

@AsToNlele AsToNlele commented Jan 23, 2024

On stage Workloads are not available, because there's no API yet. This PR includes mocked data, so others can try this feature out on stage.

Jira Link

@AsToNlele AsToNlele self-assigned this Jan 25, 2024
@AsToNlele AsToNlele added the enhancement New feature or request label Jan 25, 2024
@AsToNlele AsToNlele marked this pull request as ready for review January 25, 2024 16:04
@AsToNlele AsToNlele requested a review from a team as a code owner January 25, 2024 16:04
@codecov-commenter
Copy link

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (785f15c) 8.08% compared to head (dc63968) 8.01%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/Components/Workload/index.js 0.00% 10 Missing ⚠️
src/Components/WorkloadHeader/index.js 0.00% 10 Missing ⚠️
src/Components/Breadcrumbs/Breadcrumbs.cy.js 0.00% 8 Missing ⚠️
src/Components/Breadcrumbs/index.js 0.00% 2 Missing ⚠️
src/Components/WorkloadsListTable/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #660      +/-   ##
=========================================
- Coverage    8.08%   8.01%   -0.07%     
=========================================
  Files          67      67              
  Lines        3440    3467      +27     
  Branches      784     788       +4     
=========================================
  Hits          278     278              
- Misses       3162    3189      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fewwy
Copy link
Collaborator

Fewwy commented Jan 29, 2024

Fix the lint error and it should be merged

@Fewwy Fewwy merged commit 62d480d into RedHatInsights:master Jan 29, 2024
2 checks passed
@gkarat
Copy link
Collaborator

gkarat commented Jan 30, 2024

🎉 This PR is included in version 1.37.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants