feat(ocpadvisor-123): functional filters with mockdata #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fewwy
force-pushed
the
workloads-filters-with-mock
branch
from
1eff54e
to
0bd5112
Compare
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
AsToNlele
approved these changes
Nov 3, 2023
src/Components/Common/Tables.js
Outdated
Comment on lines
293
to
298
| const mapping = { | ||
| 1: 'low', | ||
| 2: 'moderate', | ||
| 3: 'important', | ||
| 4: 'critical', | ||
| }; |
There was a problem hiding this comment.
Really like this mapping, will propably refactor the severityTypeTotext to use this mapping and just uppercase the first letter.
Fewwy
force-pushed
the
workloads-filters-with-mock
branch
2 times, most recently
from
b53ded6
to
236eb4c
Compare
Fewwy
force-pushed
the
workloads-filters-with-mock
branch
from
9d33bb9
to
395a0e1
Compare
AsToNlele
approved these changes
Nov 7, 2023
| delete cleanedUpParams.sortDirection; | ||
| delete cleanedUpParams.offset; | ||
| delete cleanedUpParams.limit; | ||
| return Object.values(cleanedUpParams).filter((value) => !isEmpty(value)); |
There was a problem hiding this comment.
You could return this instead
Suggested change
| return Object.values(cleanedUpParams).filter((value) => !isEmpty(value)); | |
| return ( | |
| Object.values(cleanedUpParams).filter((value) => !isEmpty(value)).length > 0 | |
| ); |
and then remove the filtersApplied state, since it's not used in any effect.
Used like this: showDeleteButton: noFiltersApplied(filters)
|
/retest |
|
🎉 This PR is included in version 1.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working filters for the workloads table
No URL PARAMS YET! Gonna work on them in a separate PR
How to setup mock api:
Clone insights-results-aggregator-mock
make build (takes a few minutes for me, coffee time ☕)
2.1. can speed it up with make build -j 4 to run multiple jobs at once
make run
Test the mocked api curl localhost:8080/api/insights-results-aggregator/v2/namespaces/dvo
Run the app MOCK=true npm run start:proxy:beta
Workloads should load mocked data
How to test with local data:
You can use the mock data provided from the json file - for that you need comment out data from props and use json