Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki needs a bit of improvement #41

Closed
Reonarudo opened this issue Jun 13, 2017 · 2 comments
Closed

Wiki needs a bit of improvement #41

Reonarudo opened this issue Jun 13, 2017 · 2 comments
Assignees
Labels

Comments

@Reonarudo
Copy link

The wiki page is a bit badly structured making the Rx example very incomplete.
I would suggest adding a page with a better example of its usage, the needed/possible import versions like compile 'io.fotoapparat.fotoapparat:adapter-rxjava2:1.0.2' and maybe start adding Kotlin examples.

@Diolor Diolor added the feature label Jun 13, 2017
@Diolor Diolor self-assigned this Jun 13, 2017
@Diolor
Copy link
Member

Diolor commented Jun 13, 2017

Thanks for the feedback @Reonarudo. What would you add regarding Kotlin?
Ofc PRs are welcome :)

@Diolor
Copy link
Member

Diolor commented Jun 16, 2017

The setup instructions are already under the relevant adapter README e.g. https://github.com/Fotoapparat/Fotoapparat/tree/master/fotoapparat-adapters/rxjava.

Should be easy to follow for a beginner in Rx. If not, please propose us enhancements :)

Honestly, there is much value in adding Kotlin examples since there are no huge differences between Java and Kotlin and one can easily understand both.

Will close for now but feel free to add more comments or open another issue if you need 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants