Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error displaying when trying to use multiple files for definition reference #96

Closed
nchudleigh opened this issue Aug 31, 2016 · 9 comments
Assignees

Comments

@nchudleigh
Copy link

screen shot 2016-08-31 at 3 32 50 pm

My file structure looks like this:
screen shot 2016-08-31 at 3 33 48 pm

swagger.json has all the paths and parameters, I am trying to reference the definitions in the path parameters (in swagger.json) and I am getting this error. The odd thing is the references work for ONE endpoint but not multiple.

I am using swagger-tools to validate the swagger.json file and it seems to be fine

@nchudleigh nchudleigh changed the title Error displaying when trying to use multiple files for reference Error displaying when trying to use multiple files for definition reference Aug 31, 2016
@RomanHotsiy
Copy link
Member

@nchudleigh could you please provide more details?

  1. browser console output
  2. parts of spec (can be simplified) where you reference external definitions (if it is possible would be great if you share all your files - you can send them to my email)

Thanks

@nchudleigh
Copy link
Author

Thank you for the quick reply. I have resorted to rendering all into one file for now using json-refs.

Heres a shot of the console. I have sent you the files over email.

screen shot 2016-08-31 at 4 00 39 pm

@RomanHotsiy RomanHotsiy self-assigned this Sep 28, 2016
@RomanHotsiy
Copy link
Member

I just tested on your files and can confirm this is a bug.
Will look into this.

@nchudleigh
Copy link
Author

Great thanks 👍

@camillu
Copy link

camillu commented Nov 8, 2016

I'm getting a similar issue when using $ref for external .json files. I will be sending you an email with a minimal sample that reproduces the issue. It is not exactly the same for us, as for example, a different spec which is structurally similar (references multiple .json files) is not affected by this bug. Thanks.

@RomanHotsiy
Copy link
Member

@camillu thanks for sending minimal sample.
I was able to reproduce the issue. Also I have managed to fix it.

Fix will be shipped in the next release. I will let you know.

@camillu
Copy link

camillu commented Nov 8, 2016

Thank you so much!

@RomanHotsiy
Copy link
Member

FYI: new release has been shipped (actually some time ago but I have remembered only now)

@camillu
Copy link

camillu commented Dec 3, 2016

Thanks! We are making use of 1.6.1 already and it's working great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants