Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase badge size slightly so that "PATCH" method fits inside better #632

Merged
merged 1 commit into from
Sep 5, 2018
Merged

Increase badge size slightly so that "PATCH" method fits inside better #632

merged 1 commit into from
Sep 5, 2018

Conversation

fredriklengstrand
Copy link
Contributor

This pull request fixes an issue where the "PATCH" method does not fit inside the badge very nicely at the cost of some horizontal space for the summary.

Before:

screen shot 2018-09-03 at 20 45 23

After:

screen shot 2018-09-03 at 20 40 03

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.137% when pulling 2d77880 on fredriklengstrand:badge-size into 822d038 on Rebilly:master.

@RomanHotsiy
Copy link
Member

Hi @fredriklengstrand, thanks for the PR.

I don't think increasing badge size is a good choice. This badge takes too much space even now.

I would prefer shortening PATCH to something like PTCH (similar to how it is done for DELETE -> DEL) or making PATCH font size a bit smaller.

What do you think?

@fredriklengstrand
Copy link
Contributor Author

Hello,

That works too even though the shortening might not be quite as obvious as the one for “DELETE” is.

Both solutions are better than how it looks now I think. :)

@RomanHotsiy RomanHotsiy merged commit 4b3b5ba into Redocly:master Sep 5, 2018
@RomanHotsiy
Copy link
Member

RomanHotsiy commented Sep 5, 2018

I tried both shortening PATCH to something like PTCH and making PATCH font size smaller and both look not so good.

Looks like making badge size bigger is the best option here.

Thanks for the PR!

@fredriklengstrand fredriklengstrand deleted the badge-size branch September 5, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants