Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MergeAllOf takes items into account #511

Merged
merged 1 commit into from
May 31, 2018
Merged

MergeAllOf takes items into account #511

merged 1 commit into from
May 31, 2018

Conversation

jderusse
Copy link
Contributor

This PR allows

      allOf:
        - type: array
          items:
            type: object
            properties:
              id:
                type: string
        - type: array
          items:
            type: object
            properties:
              name:
                type: string

And render it as

      type: array
      items:
        type: object
        properties:
          id:
            type: string
          name:
            type: string

@coveralls
Copy link

coveralls commented May 28, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 81.601% when pulling 7a64873 on jderusse:fix-all-of-array into 6b1e8e7 on Rebilly:master.

@jderusse jderusse changed the title MergeAlloF takes items into account MergeAllOf takes items into account May 28, 2018
@jderusse jderusse changed the title MergeAllOf takes items into account WIP MergeAllOf takes items into account May 28, 2018
@jderusse jderusse changed the title WIP MergeAllOf takes items into account MergeAllOf takes items into account May 28, 2018
@RomanHotsiy RomanHotsiy mentioned this pull request May 30, 2018
Closed
@RomanHotsiy RomanHotsiy merged commit 47b2177 into Redocly:master May 31, 2018
@RomanHotsiy
Copy link
Member

LGTM! Nice job 👍
Thanks @jderusse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jderusse @coveralls @RomanHotsiy