fix: update node rules

Author: RebeccaStevens

src/builtin/best-practices.ts

@@ -6,12 +6,6 @@ const useObjectDefineProperty = "Please use Object.defineProperty instead.";
 
 export const rules: Linter.Config["rules"] = {
   "accessor-pairs": "error",
-  "array-callback-return": [
-    "error",
-    {
-      allowImplicit: false,
-    },
-  ],
   "block-scoped-var": "error",
   "class-methods-use-this": "error",
   "complexity": "off",

src/builtin/deprecated.ts

@@ -0,0 +1,27 @@
+import type { Linter } from "eslint";
+
+export const rules: Linter.Config["rules"] = {
+  "callback-return": "off",
+  "global-require": "off",
+  "handle-callback-err": "off",
+  "id-blacklist": "off",
+  "indent-legacy": "off",
+  "lines-around-directive": "off",
+  "newline-after-var": "off",
+  "newline-before-return": "off",
+  "no-buffer-constructor": "off",
+  "no-catch-shadow": "off",
+  "no-mixed-requires": "off",
+  "no-native-reassign": "off",
+  "no-negated-in-lhs": "off",
+  "no-new-require": "off",
+  "no-path-concat": "off",
+  "no-process-env": "off",
+  "no-process-exit": "off",
+  "no-restricted-modules": "off",
+  "no-spaced-func": "off",
+  "no-sync": "off",
+  "prefer-reflect": "off",
+  "require-jsdoc": "off",
+  "valid-jsdoc": "off",
+};

src/builtin/index.ts

@@ -1,6 +1,7 @@
 import type { Linter } from "eslint";
 
 import { rules as bestPractices } from "./best-practices";
+import { rules as deprecated } from "./deprecated";
 import { rules as es6 } from "./es6";
 import { rules as possibleErrors } from "./possible-errors";
 import { rules as strict } from "./strict";
@@ -14,4 +15,5 @@ export const rules: Linter.Config["rules"] = {
   ...strict,
   ...stylisticIssues,
   ...variables,
+  ...deprecated,
 };

src/configs/script.ts

@@ -6,6 +6,9 @@ const baseConfig: Linter.Config = {
     "functional/no-expression-statement": "off",
     "functional/no-loop-statement": "off",
     "functional/no-throw-statement": "off",
+    "node/no-process-exit": "off",
+    "node/no-sync": "off",
+    "node/no-unpublished-import": "off",
   },
 };
 

src/plugins/node.ts

@@ -25,6 +25,7 @@ export const settings: Linter.Config = {
     "node/no-process-exit": "error",
     "node/no-sync": "error",
     "node/no-unpublished-import": "warn",
+    "node/no-unsupported-features/es-syntax": "off",
     "node/prefer-global/buffer": ["error", "always"],
     "node/prefer-global/console": ["error", "always"],
     "node/prefer-global/process": ["error", "always"],

src/plugins/unicorn.ts

@@ -13,6 +13,8 @@ export const settings: Linter.Config = {
     "unicorn/no-array-reduce": "off",
     "unicorn/no-nested-ternary": "off",
     "unicorn/no-null": "off",
+    // "node/no-process-exit" covers this.
+    "unicorn/no-process-exit": "off",
     "unicorn/no-useless-undefined": "off",
     "unicorn/prefer-at": [
       "error",