fix: don't require ts when not wanted

Author: RebeccaStevens

scripts/typegen.ts

@@ -50,6 +50,7 @@ const configs = (await combine(
   }),
   imports({
     stylistic: false,
+    typescript: false,
     parserOptions: {},
     filesTypeAware: [],
   }),

src/configs/formatters.ts

@@ -272,23 +272,23 @@ export async function formatters(
     "style/ts/space-infix-ops": "off",
     "style/ts/type-annotation-spacing": "off",
 
-    "@typescript-eslint/block-spacing": "off",
-    "@typescript-eslint/brace-style": "off",
-    "@typescript-eslint/comma-dangle": "off",
-    "@typescript-eslint/comma-spacing": "off",
-    "@typescript-eslint/func-call-spacing": "off",
-    "@typescript-eslint/indent": "off",
-    "@typescript-eslint/key-spacing": "off",
-    "@typescript-eslint/keyword-spacing": "off",
-    "@typescript-eslint/member-delimiter-style": "off",
-    "@typescript-eslint/no-extra-parens": "off",
-    "@typescript-eslint/no-extra-semi": "off",
-    "@typescript-eslint/object-curly-spacing": "off",
-    "@typescript-eslint/semi": "off",
-    "@typescript-eslint/space-before-blocks": "off",
-    "@typescript-eslint/space-before-function-paren": "off",
-    "@typescript-eslint/space-infix-ops": "off",
-    "@typescript-eslint/type-annotation-spacing": "off",
+    "ts/block-spacing": "off",
+    "ts/brace-style": "off",
+    "ts/comma-dangle": "off",
+    "ts/comma-spacing": "off",
+    "ts/func-call-spacing": "off",
+    "ts/indent": "off",
+    "ts/key-spacing": "off",
+    "ts/keyword-spacing": "off",
+    "ts/member-delimiter-style": "off",
+    "ts/no-extra-parens": "off",
+    "ts/no-extra-semi": "off",
+    "ts/object-curly-spacing": "off",
+    "ts/semi": "off",
+    "ts/space-before-blocks": "off",
+    "ts/space-before-function-paren": "off",
+    "ts/space-infix-ops": "off",
+    "ts/type-annotation-spacing": "off",
 
     "unicorn/empty-brace-spaces": "off",
     "unicorn/no-nested-ternary": "off",

src/configs/imports.ts

@@ -3,24 +3,31 @@ import type { ESLint } from "eslint";
 import { GLOB_DTS, GLOB_MJS, GLOB_MTS, GLOB_TS, GLOB_TSX } from "../globs";
 import type {
   FlatConfigItem,
+  OptionsHasTypeScript,
   OptionsTypeScriptParserOptions,
   RequiredOptionsStylistic,
 } from "../types";
 import { loadPackages } from "../utils";
 
 export async function imports(
   options: Readonly<
-    Required<RequiredOptionsStylistic & OptionsTypeScriptParserOptions>
+    Required<
+      RequiredOptionsStylistic &
+        OptionsTypeScriptParserOptions &
+        OptionsHasTypeScript
+    >
   >,
 ): Promise<FlatConfigItem[]> {
-  const { stylistic, parserOptions } = options;
+  const { stylistic, parserOptions, typescript } = options;
 
-  const [pluginImport] = (await loadPackages([
-    "eslint-plugin-import-x",
-    "eslint-import-resolver-typescript",
-  ])) as [ESLint.Plugin, ESLint.Plugin];
-
-  const stylisticEnforcement = stylistic === false ? "off" : "error";
+  const [pluginImport] = (await loadPackages(
+    typescript
+      ? [
+          "eslint-plugin-import-x",
+          "eslint-import-resolver-typescript", // make sure it exists - we only implicitly use it
+        ]
+      : ["eslint-plugin-import-x"],
+  )) as [ESLint.Plugin] | [ESLint.Plugin, unknown];
 
   return [
     {
@@ -36,16 +43,24 @@ export async function imports(
         "import-x/internal-regex": "^(?:#|(?:@|~)\\/).*",
         "import-x/extensions": [".ts", ".tsx", ".js", ".jsx"],
         "import-x/parsers": {
-          "@typescript-eslint/parser": [".ts", ".tsx", ".cts", ".mts"],
+          ...(typescript
+            ? {
+                "@typescript-eslint/parser": [".ts", ".tsx", ".cts", ".mts"],
+              }
+            : undefined),
         },
         "import-x/resolver": {
-          typescript: {
-            alwaysTryTypes: true,
-            projectService: parserOptions.projectService,
-          },
           node: {
             extensions: [".ts", ".tsx", ".js", ".jsx"],
           },
+          ...(typescript
+            ? {
+                typescript: {
+                  alwaysTryTypes: true,
+                  projectService: parserOptions.projectService,
+                },
+              }
+            : undefined),
         },
       },
       rules: {
@@ -139,9 +154,12 @@ export async function imports(
         // "import/prefer-default-export": "off",
         // "import/unambiguous": "off",
 
-        "import/newline-after-import": [stylisticEnforcement, { count: 1 }],
+        "import/newline-after-import": [
+          stylistic === false ? "off" : "error",
+          { count: 1 },
+        ],
         "import/order": [
-          stylisticEnforcement,
+          stylistic === false ? "off" : "error",
           {
             alphabetize: {
               caseInsensitive: false,
@@ -167,24 +185,28 @@ export async function imports(
         "import/no-dynamic-require": "error",
       },
     },
-    {
-      files: [GLOB_TS, GLOB_TSX, GLOB_DTS],
-      rules: {
-        "import/no-unresolved": "off",
-        "import/named": "off",
-        "import/default": "off",
-        "import/namespace": "off",
-
-        "ts/no-import-type-side-effects": "error",
-        "ts/consistent-type-imports": [
-          stylisticEnforcement,
+    ...((typescript
+      ? [
           {
-            prefer: "type-imports",
-            fixStyle: "inline-type-imports",
-            disallowTypeAnnotations: false,
+            files: [GLOB_TS, GLOB_TSX, GLOB_DTS],
+            rules: {
+              "import/no-unresolved": "off",
+              "import/named": "off",
+              "import/default": "off",
+              "import/namespace": "off",
+
+              "ts/no-import-type-side-effects": "error",
+              "ts/consistent-type-imports": [
+                stylistic === false ? "off" : "error",
+                {
+                  prefer: "type-imports",
+                  fixStyle: "inline-type-imports",
+                  disallowTypeAnnotations: false,
+                },
+              ],
+            },
           },
-        ],
-      },
-    },
+        ]
+      : []) satisfies FlatConfigItem[]),
   ];
 }

src/factory.ts

@@ -201,6 +201,7 @@ export async function rsEslint(
     imports({
       ...typescriptConfigOptions,
       stylistic: stylisticOptions,
+      typescript: hasTypeScript,
     }),
     jsdoc({
       stylistic: stylisticOptions,