feat: add new eslint rules and configure for use with eslint-functional 5

Author: RebeccaStevens

src/builtin/es6.ts

@@ -1,19 +1,13 @@
 import type { Linter } from "eslint";
 
-import { rules as bestPractices } from "./best-practices";
 import { rules as deprecated } from "./deprecated";
-import { rules as es6 } from "./es6";
-import { rules as possibleErrors } from "./possible-errors";
-import { rules as strict } from "./strict";
-import { rules as stylisticIssues } from "./stylistic-issues";
-import { rules as variables } from "./variables";
+import { rules as layout } from "./layout+formatting";
+import { rules as possibleProblems } from "./possible-problems";
+import { rules as suggestions } from "./suggestions";
 
 export const rules: Linter.Config["rules"] = {
-  ...bestPractices,
-  ...es6,
-  ...possibleErrors,
-  ...strict,
-  ...stylisticIssues,
-  ...variables,
+  ...possibleProblems,
+  ...suggestions,
+  ...layout,
   ...deprecated,
 };

src/builtin/index.ts

@@ -2,6 +2,8 @@ import type { Linter } from "eslint";
 
 export const rules: Linter.Config["rules"] = {
   "array-bracket-spacing": ["error", "never"],
+  "arrow-parens": ["error", "always"],
+  "arrow-spacing": ["error", { before: true, after: true }],
   "block-spacing": ["error", "always"],
   "brace-style": "error",
   "capitalized-comments": "off",
@@ -19,12 +21,14 @@ export const rules: Linter.Config["rules"] = {
   "comma-style": ["error", "last"],
   "computed-property-spacing": "error",
   "consistent-this": "off",
+  "dot-location": ["error", "property"],
   "eol-last": "error",
   "func-call-spacing": ["error", "never"],
   "func-name-matching": "error",
   "func-names": ["error", "as-needed"],
   "func-style": ["error", "declaration", { allowArrowFunctions: true }],
   "function-paren-newline": "off",
+  "generator-star-spacing": ["error", "after"],
   "implicit-arrow-linebreak": "off",
   "indent": [
     "error",
@@ -160,6 +164,12 @@ export const rules: Linter.Config["rules"] = {
   "no-underscore-dangle": "off",
   "no-unneeded-ternary": "error",
   "no-whitespace-before-property": "error",
+  "no-multi-spaces": [
+    "error",
+    {
+      ignoreEOLComments: true,
+    },
+  ],
   "nonblock-statement-body-position": [
     "error",
     "beside",
@@ -230,6 +240,7 @@ export const rules: Linter.Config["rules"] = {
       allowTemplateLiterals: true,
     },
   ],
+  "rest-spread-spacing": ["error", "never"],
   "semi": ["error", "always"],
   "semi-spacing": ["error", { before: false, after: true }],
   "semi-style": ["error", "last"],
@@ -267,7 +278,15 @@ export const rules: Linter.Config["rules"] = {
     },
   ],
   "switch-colon-spacing": ["error", { after: true, before: false }],
+  "template-curly-spacing": ["error", "never"],
   "template-tag-spacing": ["error", "never"],
   "unicode-bom": ["error", "never"],
-  "wrap-regex": "off",
+  "wrap-iife": [
+    "error",
+    "inside",
+    {
+      functionPrototypeMethods: true,
+    },
+  ],
+  "yield-star-spacing": ["error", "after"],
 };

src/builtin/stylistic-issues.ts renamed to src/builtin/layout+formatting.ts

@@ -1,20 +1,24 @@
 import type { Linter } from "eslint";
 
 export const rules: Linter.Config["rules"] = {
+  "constructor-super": "error",
   "for-direction": "error",
   "getter-return": "error",
   "no-await-in-loop": "error",
   "no-compare-neg-zero": "error",
   "no-cond-assign": ["error", "always"],
   "no-console": "off",
+  "no-constant-binary-expression": "error",
   "no-constant-condition": "error",
+  "no-constructor-return": "error",
   "no-control-regex": "error",
   "no-debugger": "warn",
   "no-dupe-args": "error",
   "no-dupe-keys": "error",
   "no-duplicate-case": "error",
-  "no-empty": ["warn", { allowEmptyCatch: true }],
   "no-empty-character-class": "error",
+  "no-empty-pattern": "error",
+  "no-empty": ["warn", { allowEmptyCatch: true }],
   "no-ex-assign": "error",
   "no-extra-boolean-cast": "error",
   "no-extra-parens": [
@@ -24,21 +28,51 @@ export const rules: Linter.Config["rules"] = {
       nestedBinaryExpressions: false,
     },
   ],
+  "no-class-assign": "error",
+  "no-const-assign": "error",
+  "no-dupe-class-members": "error",
+  "no-duplicate-imports": "off",
   "no-extra-semi": "error",
+  "no-fallthrough": "error",
   "no-func-assign": "error",
   "no-inner-declarations": ["error", "functions"],
   "no-invalid-regexp": "error",
   "no-irregular-whitespace": "error",
   "no-misleading-character-class": "error",
+  "no-new-symbol": "error",
   "no-obj-calls": "error",
+  "no-promise-executor-return": "error",
   "no-prototype-builtins": "error",
   "no-regex-spaces": "error",
+  "no-self-assign": "error",
+  "no-self-compare": "error",
   "no-sparse-arrays": "error",
   "no-template-curly-in-string": "warn",
+  "no-this-before-super": "error",
+  "no-undef": "error",
   "no-unexpected-multiline": "error",
+  "no-unmodified-loop-condition": "error",
+  "no-unreachable-loop": "error",
   "no-unreachable": "error",
   "no-unsafe-finally": "error",
   "no-unsafe-negation": "error",
+  "no-unused-private-class-members": "error",
+  "no-unused-vars": [
+    "error",
+    {
+      vars: "all",
+      args: "after-used",
+      ignoreRestSiblings: true,
+    },
+  ],
+  "no-use-before-define": [
+    "error",
+    {
+      functions: true,
+      classes: true,
+      variables: true,
+    },
+  ],
   "require-atomic-updates": "error",
   "use-isnan": "error",
   "valid-typeof": [

src/builtin/possible-errors.ts renamed to src/builtin/possible-problems.ts

@@ -6,40 +6,40 @@ const useObjectDefineProperty = "Please use Object.defineProperty instead.";
 
 export const rules: Linter.Config["rules"] = {
   "accessor-pairs": "error",
+  "arrow-body-style": ["error", "as-needed"],
   "block-scoped-var": "error",
   "class-methods-use-this": "error",
-  "complexity": "off",
   "consistent-return": [
     "error",
     {
       treatUndefinedAsUnspecified: false,
     },
   ],
   "curly": ["error", "all"],
-  "default-case": "off",
-  "dot-location": ["error", "property"],
+  "default-case-last": "error",
+  "default-param-last": "error",
   "dot-notation": "error",
   "eqeqeq": ["error", "always", { null: "always" }],
+  "grouped-accessor-pairs": "error",
   "guard-for-in": "error",
+  "init-declarations": "off",
+  "logical-assignment-operators": "error",
   "max-classes-per-file": ["error", 1],
   "no-alert": "error",
   "no-caller": "error",
   "no-case-declarations": "error",
-  "no-div-regex": "off",
   "no-else-return": [
     "error",
     {
       allowElseIf: false,
     },
   ],
-  "no-empty-function": ["error"],
-  "no-empty-pattern": "error",
+  "no-empty-function": "error",
   "no-eq-null": "error",
   "no-eval": "error",
   "no-extend-native": "error",
   "no-extra-bind": "error",
   "no-extra-label": "error",
-  "no-fallthrough": "error",
   "no-floating-decimal": "error",
   "no-global-assign": "error",
   "no-implicit-coercion": "error",
@@ -50,19 +50,13 @@ export const rules: Linter.Config["rules"] = {
   "no-labels": "error",
   "no-lone-blocks": "error",
   "no-loop-func": "error",
-  "no-magic-numbers": "off",
-  "no-multi-spaces": [
-    "error",
-    {
-      ignoreEOLComments: true,
-    },
-  ],
   "no-multi-str": "off",
-  "no-new": "error",
   "no-new-func": "error",
+  "no-new-object": "error",
   "no-new-wrappers": "error",
-  "no-octal": "error",
+  "no-new": "error",
   "no-octal-escape": "error",
+  "no-octal": "error",
   "no-param-reassign": "error",
   "no-proto": "error",
   "no-redeclare": "error",
@@ -111,41 +105,80 @@ export const rules: Linter.Config["rules"] = {
       property: "__defineSetter__",
       message: useObjectDefineProperty,
     },
+  ],
+  "object-shorthand": "error",
+  "no-delete-var": "error",
+  "no-label-var": "error",
+  "no-restricted-globals": [
+    "error",
     {
-      object: "Math",
-      property: "pow",
-      message: "Use the exponentiation operator (**) instead.",
+      name: "event",
+      message: "Use local parameter instead.",
     },
   ],
   "no-return-assign": "error",
   "no-return-await": "error",
   "no-script-url": "error",
-  "no-self-assign": "error",
-  "no-self-compare": "error",
   "no-sequences": "error",
+  "no-shadow": [
+    "warn",
+    {
+      builtinGlobals: false,
+      hoist: "never",
+      allow: ["resolve", "reject", "done", "cb"],
+    },
+  ],
+  "no-shadow-restricted-names": "error",
   "no-throw-literal": "error",
-  "no-unmodified-loop-condition": "error",
   "no-unused-expressions": "error",
   "no-unused-labels": "error",
   "no-useless-call": "error",
+  "no-useless-computed-key": "error",
   "no-useless-concat": "error",
+  "no-useless-constructor": "warn",
   "no-useless-escape": "error",
+  "no-useless-rename": "error",
   "no-useless-return": "error",
+  "no-var": "error",
   "no-void": "off",
   "no-warning-comments": "off",
   "no-with": "error",
-  "prefer-named-capture-group": "off",
-  "prefer-promise-reject-errors": "error",
-  "radix": "error",
-  "require-await": "off",
-  "require-unicode-regexp": "error",
-  "vars-on-top": "off",
-  "wrap-iife": [
+  "prefer-arrow-callback": "error",
+  "prefer-const": [
+    "error",
+    {
+      destructuring: "all",
+    },
+  ],
+  "prefer-destructuring": [
     "error",
-    "inside",
     {
-      functionPrototypeMethods: true,
+      VariableDeclarator: {
+        array: false,
+        object: true,
+      },
+      AssignmentExpression: {
+        array: true,
+        object: true,
+      },
+    },
+    {
+      enforceForRenamedProperties: false,
     },
   ],
+  "prefer-exponentiation-operator": "error",
+  "prefer-numeric-literals": "error",
+  "prefer-object-has-own": "error",
+  "prefer-promise-reject-errors": "error",
+  "prefer-regex-literals": "error",
+  "prefer-rest-params": "error",
+  "prefer-spread": "error",
+  "prefer-template": "error",
+  "radix": "error",
+  "require-await": "error",
+  "require-unicode-regexp": "error",
+  "require-yield": "error",
+  "strict": ["error", "never"],
+  "symbol-description": "error",
   "yoda": ["error", "never"],
 };