feat: more rules and fixups

Author: RebeccaStevens

.github/workflows/lint-prettier.yml

@@ -25,8 +25,6 @@ jobs:
     uses: ./.github/workflows/lint-markdown.yml
   lint_packages:
     uses: ./.github/workflows/lint-packages.yml
-  lint_prettier:
-    uses: ./.github/workflows/lint-prettier.yml
   lint_spelling:
     uses: ./.github/workflows/lint-spelling.yml
   type_check:
@@ -39,7 +37,6 @@ jobs:
       - lint_knip_prod
       - lint_markdown
       - lint_packages
-      - lint_prettier
       - lint_spelling
       - type_check
     runs-on: ubuntu-latest

.github/workflows/release.yml

@@ -1,15 +1,14 @@
 "*.{json,yml}":
-  - prettier --ignore-unknown --write
+  - eslint --fix
   - cspell lint --no-progress --show-suggestions --show-context --no-must-find-files --dot
 
 "*.ts":
-  - prettier --ignore-unknown --write
   - eslint --fix
   - cspell lint --no-progress --show-suggestions --show-context --no-must-find-files --dot
   - tsc-files -p tsconfig.build.json --noEmit
 
 "*.md":
-  - prettier --ignore-unknown --write
+  - eslint --fix
   - markdownlint --config=.markdownlint.json --ignore-path=.markdownlintignore
   - cspell lint --no-progress --show-suggestions --show-context --no-must-find-files --dot
 

.lintstagedrc.yml

@@ -1,10 +1,6 @@
 {
   "editor.codeActionsOnSave": {
-    "source.fixAll": "explicit",
-    "source.fixAll.eslint": "explicit",
-    "source.formatDocument": "explicit",
-    "source.organizeImports": "explicit",
-    "source.sortImports": "explicit"
+    "source.fixAll.eslint": "explicit"
   },
   "editor.defaultFormatter": "esbenp.prettier-vscode",
   "editor.formatOnSave": true,

.vscode/settings.json

@@ -37,8 +37,8 @@
     "build": "pnpm run build:node",
     "build:node": "rimraf dist && pnpm run typegen && rollup -c rollup.config.ts --configPlugin rollup-plugin-ts",
     "cz": "git-cz",
-    "lint": "pnpm run typegen && pnpm run lint:js && pnpm run lint:md && pnpm run lint:prettier && pnpm run lint:knip && pnpm run lint:spelling && pnpm run lint:packages",
-    "lint-fix": "pnpm run typegen && pnpm run lint:js-fix && pnpm run lint:prettier-fix && pnpm run lint:packages-fix",
+    "lint": "pnpm run typegen && pnpm run lint:js && pnpm run lint:md && pnpm run lint:knip && pnpm run lint:spelling && pnpm run lint:packages",
+    "lint-fix": "pnpm run typegen && pnpm run lint:js-fix && pnpm run lint:packages-fix",
     "lint:js": "eslint .",
     "lint:js-fix": "eslint . --fix",
     "lint:knip": "pnpm run lint:knip:development && pnpm run lint:knip:production",
@@ -47,8 +47,6 @@
     "lint:md": "markdownlint \"**/*.md\" --config=.markdownlint.json --ignore-path=.markdownlintignore",
     "lint:packages": "pnpm dedupe --check",
     "lint:packages-fix": "pnpm dedupe",
-    "lint:prettier": "prettier \"**/*\" --ignore-unknown --list-different",
-    "lint:prettier-fix": "prettier \"**/*\" --ignore-unknown --write",
     "lint:spelling": "cspell \"**\" \".github/**/*\"",
     "prepare": "husky && pnpm run typegen",
     "release": "semantic-release",
@@ -91,7 +89,7 @@
     "eslint-plugin-eslint-comments": "3.2.0",
     "eslint-plugin-format": "0.1.0",
     "eslint-plugin-functional": "6.3.0",
-    "eslint-plugin-import": "2.29.1",
+    "eslint-plugin-import-x": "0.5.0",
     "eslint-plugin-jsdoc": "48.2.1",
     "eslint-plugin-jsonc": "2.14.1",
     "eslint-plugin-markdown": "4.0.1",
@@ -101,6 +99,7 @@
     "eslint-plugin-perfectionist": "2.7.0",
     "eslint-plugin-prettier": "5.1.3",
     "eslint-plugin-promise": "6.1.1",
+    "eslint-plugin-regexp": "2.4.0",
     "eslint-plugin-sonarjs": "0.24.0",
     "eslint-plugin-toml": "0.10.0",
     "eslint-plugin-unicorn": "51.0.1",
@@ -145,7 +144,7 @@
     "eslint-plugin-eslint-comments": "*",
     "eslint-plugin-format": "*",
     "eslint-plugin-functional": "*",
-    "eslint-plugin-import": "*",
+    "eslint-plugin-import-x": "*",
     "eslint-plugin-jsdoc": "*",
     "eslint-plugin-jsonc": "*",
     "eslint-plugin-markdown": "*",
@@ -155,6 +154,7 @@
     "eslint-plugin-perfectionist": "*",
     "eslint-plugin-prettier": "*",
     "eslint-plugin-promise": "*",
+    "eslint-plugin-regexp": "*",
     "eslint-plugin-sonarjs": "*",
     "eslint-plugin-toml": "*",
     "eslint-plugin-unicorn": "*",
@@ -207,7 +207,7 @@
     "eslint-plugin-functional": {
       "optional": true
     },
-    "eslint-plugin-import": {
+    "eslint-plugin-import-x": {
       "optional": true
     },
     "eslint-plugin-jsdoc": {
@@ -237,6 +237,9 @@
     "eslint-plugin-promise": {
       "optional": true
     },
+    "eslint-plugin-regexp": {
+      "optional": true
+    },
     "eslint-plugin-sonarjs": {
       "optional": true
     },

package.json

@@ -14,9 +14,11 @@ jiti
 knip
 litecoin
 lockb
+lookarounds
 monero
 nocheck
 noreply
+nums
 nuxt
 plugh
 quux

pnpm-lock.yaml

@@ -9,7 +9,7 @@ export async function imports(
 ): Promise<FlatConfigItem[]> {
   const { stylistic = true } = options;
 
-  const [pluginImport] = (await loadPackages(["eslint-plugin-import"])) as [
+  const [pluginImport] = (await loadPackages(["eslint-plugin-import-x"])) as [
     ESLint.Plugin,
   ];
 
@@ -20,11 +20,19 @@ export async function imports(
         import: pluginImport,
       },
       settings: {
-        "import/external-module-folders": ["node_modules"],
-        "import/internal-regex": "^(?:#|(?:@|~)\\/).*",
-        "import/resolver": {
+        "import-x/external-module-folders": [
+          "node_modules",
+          "node_modules/@types",
+        ],
+        "import-x/internal-regex": "^(?:#|(?:@|~)\\/).*",
+        "import-x/extensions": [".ts", ".tsx", ".js", ".jsx"],
+        "import-x/parsers": {
+          "@typescript-eslint/parser": [".ts", ".tsx", ".cts", ".mts"],
+        },
+        "import-x/resolver": {
+          typescript: true,
           node: {
-            extensions: ["js", "cjs", "mjs", "ts", "cts", "mts", "jsx", "tsx"],
+            extensions: [".ts", ".tsx", ".js", ".jsx"],
           },
         },
       },