Skip to content

Commit c251ea7

Browse files
Fabio Estevambroonie
Fabio Estevam
authored andcommitted
ASoC: sgtl5000: Fix SMALL_POP bit definition
On a mx28evk with a sgtl5000 codec we notice a loud 'click' sound to happen 5 seconds after the end of a playback. The SMALL_POP bit should fix this, but its definition is incorrect: according to the sgtl5000 manual it is bit 0 of CHIP_REF_CTRL register, not bit 1. Fix the definition accordingly and enable the bit as intended per the code comment. After applying this change, no loud 'click' sound is heard after playback Signed-off-by: Fabio Estevam <[email protected]> Signed-off-by: Mark Brown <[email protected]> Cc: [email protected]
1 parent f114040 commit c251ea7

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

sound/soc/codecs/sgtl5000.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -1299,8 +1299,7 @@ static int sgtl5000_probe(struct snd_soc_codec *codec)
12991299

13001300
/* enable small pop, introduce 400ms delay in turning off */
13011301
snd_soc_update_bits(codec, SGTL5000_CHIP_REF_CTRL,
1302-
SGTL5000_SMALL_POP,
1303-
SGTL5000_SMALL_POP);
1302+
SGTL5000_SMALL_POP, 1);
13041303

13051304
/* disable short cut detector */
13061305
snd_soc_write(codec, SGTL5000_CHIP_SHORT_CTRL, 0);

sound/soc/codecs/sgtl5000.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@
275275
#define SGTL5000_BIAS_CTRL_MASK 0x000e
276276
#define SGTL5000_BIAS_CTRL_SHIFT 1
277277
#define SGTL5000_BIAS_CTRL_WIDTH 3
278-
#define SGTL5000_SMALL_POP 0x0001
278+
#define SGTL5000_SMALL_POP 0
279279

280280
/*
281281
* SGTL5000_CHIP_MIC_CTRL

0 commit comments

Comments
 (0)