Skip to content

Commit 84bc886

Browse files
Vincent BENAYOUNdavem330
Vincent BENAYOUN
authored andcommitted
inetdevice: fixed signed integer overflow
There could be a signed overflow in the following code. The expression, (32-logmask) is comprised between 0 and 31 included. It may be equal to 31. In such a case the left shift will produce a signed integer overflow. According to the C99 Standard, this is an undefined behavior. A simple fix is to replace the signed int 1 with the unsigned int 1U. Signed-off-by: Vincent BENAYOUN <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent b23dc5a commit 84bc886

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/linux/inetdevice.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ static inline void in_dev_put(struct in_device *idev)
242242
static __inline__ __be32 inet_make_mask(int logmask)
243243
{
244244
if (logmask)
245-
return htonl(~((1<<(32-logmask))-1));
245+
return htonl(~((1U<<(32-logmask))-1));
246246
return 0;
247247
}
248248

0 commit comments

Comments
 (0)