Drop all Internet Explorer support into a pit of flames! 🔥 IE 🔥 #7184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
reviewed
Feb 19, 2023
src/internal/ajax/getXHRResponse.ts
Outdated
| } | ||
| } | ||
| } | ||
| return xhr.responseType === 'document' ? xhr.responseXML : xhr.response; |
There was a problem hiding this comment.
Honestly, we should just inline this if it's only used in one spot. It's a small amount of code now.
There was a problem hiding this comment.
Judging from the specification, the use of responseXML is redundant, since response fully covers our requirements.
Otherwise, if this’s response type is "document", set a document response for this.
So I replaced getXHRResponse(xhr) with xhr.response.
BREAKING CHANGE: `ajax` no longer supports IE
benlesh
approved these changes
Mar 7, 2023
|
Thanks, @demensky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
ajaxno longer supports IERelated issue (if exists): #6367