chore: deprecate MapTo variants #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlesh
added
7.x
Deprecating MapTo variants, as they were only wrappers around the Map variants, and added unnecessary API surface area. related ReactiveX#6367 resolves ReactiveX#6399
benlesh
force-pushed
the
deprecate-MapTo-variants
branch
from
b4b44d1 to
6a6798e
Compare
cartant
reviewed
Mar 5, 2022
There was a problem hiding this comment.
Some of the dtslint tests are failing:
ERROR: /home/runner/work/rxjs/rxjs/spec-dtslint/operators/mapTo-spec.ts:17:47 - No deprecation found
ERROR: /home/runner/work/rxjs/rxjs/spec-dtslint/operators/mergeMapTo-spec.ts:80:56 - No deprecation found
It looks like the mapTo signature that's being matched doesn't have a deprecation tag and mergeMapTo does not appear to have any deprecation tags.
cartant
approved these changes
Mar 7, 2022
| @@ -2,7 +2,7 @@ import { switchMap } from './switchMap'; | |||
| import { ObservableInput, OperatorFunction, ObservedValueOf } from '../types'; | |||
| import { isFunction } from '../util/isFunction'; | |||
|
|
|||
| /* tslint:disable:max-line-length */ | |||
| /** @deprecated Will be removed in v9. Use {@link mergeMap} instead: `mergeMap(() => result)` */ | |||
There was a problem hiding this comment.
Why is mergeMap the recommended substitution for switchMapTo?
alcaidio
reviewed
Mar 23, 2022
| @@ -55,6 +54,7 @@ export function switchMapTo<T, R, O extends ObservableInput<unknown>>( | |||
| * `resultSelector`) every time a value is emitted on the source Observable, | |||
| * and taking only the values from the most recently projected inner | |||
| * Observable. | |||
| * @deprecated Will be removed in v9. Use {@link mergeMap} instead: `mergeMap(() => result)` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecating MapTo variants, as they were only wrappers around the Map variants, and added unnecessary API surface area.
related #6367