Skip to content

Update defaultIfEmpty tests to run mode #5820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cartant merged 2 commits into from
Oct 14, 2020
Merged

Update defaultIfEmpty tests to run mode #5820

cartant merged 2 commits into from
Oct 14, 2020

Conversation

@jakovljevic-mladen
Copy link
Member

@jakovljevic-mladen jakovljevic-mladen commented Oct 11, 2020

Updated defaultIfEmpty tests to use run mode.

benlesh
benlesh reviewed Oct 13, 2020
View reviewed changes
cartant
cartant approved these changes Oct 14, 2020
View reviewed changes
Copy link
Collaborator

@cartant cartant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cartant cartant merged commit 0d3094f into ReactiveX:master Oct 14, 2020
@jakovljevic-mladen jakovljevic-mladen deleted the defaultIfEmpty_run_mode branch October 14, 2020 06:29
jakovljevic-mladen added a commit to jakovljevic-mladen/rxjs that referenced this pull request Oct 28, 2020
@jakovljevic-mladen
chore: update imports
66b6ce2 
See ReactiveX#5820
@jakovljevic-mladen jakovljevic-mladen mentioned this pull request Oct 28, 2020
Merged
cartant pushed a commit that referenced this pull request Oct 29, 2020
@jakovljevic-mladen
Test fixes (#5864)
b5b4c12 
* chore: revert use of of()

See #5860

* chore: update imports

See #5820

* chore: remove passing scheduler in debounceTime tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benlesh benlesh benlesh left review comments

@cartant cartant cartant approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jakovljevic-mladen @benlesh @cartant