Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Subscription): Get rid of _unsubscribe weirdness #5670

Commits on Aug 23, 2020

  1. refactor(Subscription): Get rid of _unsubscribe weirdness

    This is just another step toward getting what we're doing with inheritance to be a little more sane, ultimately, this may be refactored further, as I am not happy with some of these subscribers adding their own teardowns, but this is a start. The goal was to get rid of the weirdness around `_unsubscribe` in our code base.
    
    - Moves to calling `_unsubscribe` a new internal name in `Subscription`: `initialTeardown`, because it's slightly more descriptive
    - Removes `_unsubscribe` usage from the entire codebase.
    - Formatted a few files just for my sanity.
    benlesh committed Aug 23, 2020
    Configuration menu
    Copy the full SHA
    4c171fe View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. chore: address comments

    benlesh committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    1e58308 View commit details
    Browse the repository at this point in the history