refactor(Subscription): Get rid of _unsubscribe weirdness #5670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just another step toward getting what we're doing with inheritance to be a little more sane, ultimately, this may be refactored further, as I am not happy with some of these subscribers adding their own teardowns, but this is a start. The goal was to get rid of the weirdness around `_unsubscribe` in our code base. - Moves to calling `_unsubscribe` a new internal name in `Subscription`: `initialTeardown`, because it's slightly more descriptive - Removes `_unsubscribe` usage from the entire codebase. - Formatted a few files just for my sanity.
|
In retrospect, I might be able to just have a |
cartant
approved these changes
Aug 25, 2020
| (this as any)._unsubscribe = unsubscribe; | ||
| } | ||
| } | ||
| constructor(private initialTeardown?: () => void) {} |
| @@ -80,6 +80,7 @@ class WindowSubscriber<T> extends SimpleOuterSubscriber<T, any> { | |||
|
|
|||
| constructor(destination: Subscriber<Observable<T>>) { | |||
| super(destination); | |||
| this.add(this._teardown); | |||
There was a problem hiding this comment.
suggestion: (as above) this.add(this._teardown.bind(this))?
| @@ -90,6 +90,7 @@ class WindowToggleSubscriber<T, O> extends ComplexOuterSubscriber<T, any> { | |||
| private openings: Observable<O>, | |||
| private closingSelector: (openValue: O) => Observable<any>) { | |||
| super(destination); | |||
| this.add(this._teardown); | |||
There was a problem hiding this comment.
suggestion: (as above) this.add(this._teardown.bind(this))?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just another step toward getting what we're doing with inheritance to be a little more sane, ultimately, this may be refactored further, as I am not happy with some of these subscribers adding their own teardowns, but this is a start. The goal was to get rid of the weirdness around
_unsubscribein our code base._unsubscribea new internal name inSubscription:initialTeardown, because it's slightly more descriptive_unsubscribeusage from the entire code base.