Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(buffer): rename buffer to bufferWith #5575

Closed
wants to merge 2 commits into from
Closed

refactor(buffer): rename buffer to bufferWith #5575

wants to merge 2 commits into from

Conversation

tylersaunders
Copy link

Description: renames the buffer operator to bufferWith and marks buffer as deprecated

Related issue (if exists): #5296

renames the buffer operator to bufferWith and marks buffer as deprecated

issue: 5296
@tylersaunders
Copy link
Author

Looks like api_guardian is failing, but I'm not sure how to resolve this. Hoping the owners can point me in the right direction, as I haven't been able to find any documentation around it, and it's not mentioned in COLLABORATORS.md

@benlesh
Copy link
Member

benlesh commented Sep 2, 2020

I think this one is a near-miss, unfortunately.

The ones we are marking "___With" are the operators that have a static creation function counterpart. concat and concatWith, or merge and mergeWith. Unfortunately, there's no static creation function for buffer.

@benlesh benlesh closed this Sep 2, 2020
@benlesh
Copy link
Member

benlesh commented Sep 2, 2020

Thank you so much for your effort, @tylersaunders. It is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants