feat(start): start method added to observers and subjects #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, I'm going to need to make sure that you can't call start after it's been called once. We don't need user-land code calling it. |
Generated by 🚫 dangerJS |
---3.7KB-green.svg?style=flat-square){kind=icon}
-+0.2KB-red.svg?style=flat-square){kind=icon}
In order to match the TC39 and WHATWG proposals, a `start` method has been added to the `Observer` interface. The start method is fired prior to the Observable initializing, and it is handed the same `Subscription` object that is returned from the subscribe call. This enables consumers to get a handle on the subscription and unsubscribe early in the event of a synchronous firehose that they want to stop. resolves #3061
|
I'm not sure this is the route we're going to go with this. Closing for now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to match the TC39 and WHATWG proposals, a
startmethod has been added to theObserverinterface. The start method is fired prior to the Observable initializing, and it is handed the sameSubscriptionobject that is returned from the subscribe call. This enables consumers to get a handle on the subscription and unsubscribe early in the event of a synchronous firehose that they want to stop.resolves #3061