dont' -> don't

[rgbkrk]

let me just say I'm super freakin' excited for the lettable operators, thanks for this

[kwonoj]

🚢

[kwonoj]

@rgbkrk off-topic, how do you deal with module sizes in Electron? doing bundling via webpack or something else?

[rxjs-bot]

	Messages
📖

CJS: 1342.5KB, global: 737.3KB (gzipped: 137.9KB), min: 144.6KB (gzipped: 30.7KB)

Generated by 🚫 dangerJS

[rgbkrk]

how do you deal with module sizes in Electron? doing bundling via webpack or something else?

We bundle both the main and renderer process with webpack: https://github.com/nteract/nteract/blob/d84fcc3d2ac3b16987ba3b6548fdeda76feda91d/packages/desktop/webpack.config.js#L25-L44

By the way I'm more than pleased to tune into the bikeshedding on the operator names, as I think we're definitely going to want to adopt these now because of some current lerna + hoisting issues.

[rgbkrk]

Oh -- one other sneaky trick we do @kwonoj -- since we do bundling with webpack we stick (most) of our dependencies in devDependencies: https://github.com/nteract/nteract/blob/d84fcc3d2ac3b16987ba3b6548fdeda76feda91d/packages/desktop/package.json#L103

That cuts down on which node_modules end up in the shipped app

[kwonoj]

Oh that's interesting, I should take a peek 🙇

[kwonoj]

@rgbkrk when you have some free time, mind if I poke you for chat with coffee around packaging (mostly bundling) strategy in nteract? ☕️

[rgbkrk]

@kwonoj I would love that!

[coveralls]

Coverage remained the same at ?% when pulling ffaf538 on rgbkrk:patch-1 into 2e576dc on ReactiveX:master.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.