fix: Make WebSocketSubjectConfig a generic type

[fangpenlin]

Description:

Fix typescript type issue for websocket #2754, make WebSocketSubjectConfig a generic type, so that it will respect the type T from websocket.

In this way, the type can be inferred correctly from the resultSelector's result type, you can write something like

const myWebSocket = webSocket({
  url: 'ws://localhost:8080',
  resultSelector: (e: MessageEvent) => e.data + '!'
})

the myWebSocket will automatically inferred as WebSocketSubject<string>

[fangpenlin]

Hmmm, not sure what about default type

const myWebSocket = webSocket({
  url: 'ws://localhost:8080'
})

it seems by default the T will get inferred to be {} strangely in this case. Maybe we should make the T default to any, as the default resultSelector is implementing as a JSON parser?

[kwonoj]

I guess this should target next branch with default generic features in TS compiler.

[rxjs-bot]

	Messages
📖

CJS: 3174.1KB, global: 588.9KB (gzipped: 108.6KB), min: 138.0KB (gzipped: 29.1KB)

Generated by 🚫 dangerJS

[coveralls]

Coverage remained the same at 97.734% when pulling faf0d72 on fangpenlin:fang/bugfix2754/inferening-correct-type-for-websocket-result-selector into 491970f on ReactiveX:master.

[fangpenlin]

@kwonoj

sorry, maybe we should hold on a little bit on this PR, just tried, even with default generic type

export class WebSocketSubject<T = any> extends AnonymousSubject<T> {

Somehow we are still getting {} as the inferred type if resultSelector is not given :/

I am not sure how TypeScript works in terms of getting {} out of undefined resultSelector, that's really odd behavior

[benlesh]

This is done in master.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.