Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJS 7 Modules/Types/Package Structure Epic #6549

Open
11 tasks
benlesh opened this issue Aug 9, 2021 · 2 comments
Open
11 tasks

RxJS 7 Modules/Types/Package Structure Epic #6549

benlesh opened this issue Aug 9, 2021 · 2 comments
Labels
8.x Issues and PRs for version 8.x

Comments

@benlesh
Copy link
Member

benlesh commented Aug 9, 2021

There's been a smattering of issues around our package structure, locating types, pulling in the proper versions, etc.

  • Ensure ESM users are getting ES2015/ESM build (must be 8.x)
  • Ensure CJS users are getting CJS build
  • Ensure those that want ES5 (whomever they are?) are getting ES5 build (not supported in 8.x)
  • Ensure it works with the latest Angular-CLI
  • Ensure it works with the latest Create React App
  • Ensure it works with Vite/Vue builds
  • Ensure it works generally with Rollup/Webpack
  • (Somehow) ensure it works with Stackblitz
  • Make sure people don't end up with two versions of RxJS in mixed environments, if possible. (e.g. import { Observable as Observable1 } from 'rxjs'; require('rxjs').Observable === Observable1) Again, I'm not even sure this is possible
  • Figure out some sort of way to test this in CI so it doesn't happen again.
  • Figure out if there are any Electron issues

Related Issues:

@benlesh benlesh added 7.x Issues and PRs for version 7.x 8.x Issues and PRs for version 8.x AGENDA ITEM Flagged for discussion at core team meetings labels Aug 9, 2021
@benlesh
Copy link
Member Author

benlesh commented Aug 9, 2021

One relevant link from the other issue is a link to possible solutions for module resolution and how to set up the package.json.

This relates a bit to work that @samccone did for us in #6192. So I'd love your input, too Sam.

@benlesh
Copy link
Member Author

benlesh commented Aug 11, 2021

Core Team Meeting: (low attendance) - We may have to wait for v8. Would like to move to package that only includes ESM and CJS. (Getting rid of UMD and ESM5)

@kwonoj suggests maybe publish "Real ESM" modules in another package. @benlesh says we should publish the current "Sorta ESM" (ala what Rollup/Webpack/etc leverage) and CJS in the rxjs module, but drop UMD and ESM5 dead weight in version 8.

@benlesh benlesh removed AGENDA ITEM Flagged for discussion at core team meetings 7.x Issues and PRs for version 7.x labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.x Issues and PRs for version 8.x
Projects
None yet
Development

No branches or pull requests

1 participant