-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-type-related issues for v7 beta #5372
Comments
|
benlesh
added a commit
to benlesh/rxjs
that referenced
this issue
Oct 7, 2020
Fixes an issue were accumulated state would be emitted a second time upon completion. BREAKING CHANGE: `mergeScan` will no longer emit its inner state again upon completion. related ReactiveX#5372
benlesh
added a commit
that referenced
this issue
Oct 8, 2020
* fix(mergeScan): No longer emits state again upon completion. Fixes an issue were accumulated state would be emitted a second time upon completion. BREAKING CHANGE: `mergeScan` will no longer emit its inner state again upon completion. related #5372 * chore(lint): remove unused import Co-authored-by: Nicholas Jamieson <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is for tracking non-type-related issues - type-related issues are in #5066 - that could/should be addressed in the v7 beta.
hostReportError
for swallowed errors - Exception not thrown when maximum call stack is exceeded #5370 (From @benlesh: Here we opted to add a skipped test that we can "unskip" when we get to the larger refactor in v8)console.warn
still seems to be used instead ofhostReportError
- see this commentaudit
has this problem, too.All operators that have a notifier need to be checked. (the only remaining PR on this one is here: fix(delayWhen): no longer emits if duration selector is empty #5769)Nope, there are a whole bunch of operators that treatnext
andcomplete
identically in notifiers/selectors. See Complete notifications deemed to be signals #5838 and fix: don't treat notifier completion as a signal #5853 (the PR)mergeScan
has strange behaviour upon the completion of the inner observable - see here - this should be changed. (PR here: fix(mergeScan): No longer emits state again upon completion. #5805)animationFrames
should use the API'sDOMHighResTimeStamp
- animationFrames should emit the timestamp from requestAnimationFrame's callback #5194finalize
is dodgy AF - see Finalize is not called at end of pipe, different results with delay #5357 and issues linked therein.Subscribable
sources withoutSymbol.observable
- see from is typed to accept any Subscribable, but only accepts Observables with Symbol.observable #4532@internal
- see Mark publicly-visible internal properties as @internal #5768lib
for RxJS isES2018
, as that's when async iterables were introduced. That issue is that, our type inference tests assume that the types inES2018
are available and weird things can happen if they are not. See Impose a minimum TS lib for version 7. #5708. chore: add triple-slash ref to asynciterable #5807 adds a workaround, but I think it's still worth documenting. Maybe reference this blog post? Not sure where this would go in the docs.Do Not Block The Release
concurrency
parameter forconactMap
- see Allow concurrency inconcatMap
#5519 (mergeInternals
could be extended to take aconcat
orcollate
flag)The text was updated successfully, but these errors were encountered: