Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Renaming suggestion for publishLast #4949

Closed
1 of 5 tasks
BioPhoton opened this issue Aug 5, 2019 · 2 comments
Closed
1 of 5 tasks

[docs]: Renaming suggestion for publishLast #4949

BioPhoton opened this issue Aug 5, 2019 · 2 comments

Comments

@BioPhoton
Copy link
Contributor

Documentation Related To Component:

The publishLast operator:
publishLast.ts

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

Publish operators are named after their used Subject. This helps the API consumer to understand intuitively and quickly what the operator will do. An exception is the publishLast operator.

See a list of publish operators and their Subjects here:

  • publish => Subject
  • publishBehavior => BehaviorSubject
  • publishReplay => RpleaySubject
  • publishLast => AsyncSubject

My suggestion now is to rename publishLast to publishAsync . This would make the whole naming consistent.

@BioPhoton
Copy link
Contributor Author

Just remembered that there is also this renaming.

This will change the situation a bit. But the issue is still valid because we would have to adopt the naming of the publish operators too.

@cartant
Copy link
Collaborator

cartant commented Apr 30, 2021

Closing this because publishLast is deprecated in v7.

@cartant cartant closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants