Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs]: Rename/Alias pairs to entries to provide a more intuitive/JS-aligned API #4644

Closed
BioPhoton opened this issue Mar 16, 2019 · 1 comment

Comments

@BioPhoton
Copy link
Contributor

BioPhoton commented Mar 16, 2019

Bug Report

We could rename/alias pairs into entries as it is exactly what the js Object first-class function entries are doing.
As far as is know @benlesh implemented this operator. So maybe he knows best for what reason the naming is why it is.

Also, the source code could be improved as the API changed since it'S implementation and I believe we could go with Object.entries, but maybe this updating of the code should be a separate issue.

I'll wait for feedback here. :)

Furthermore, the description section could be improved compared to the short description section.

Current Behavior
All good!

Reproduction
No bug present

Expected behavior
Behavior is perfect

Possible Solution
Introducing Alias

Additional context/Screenshots

import {of} from 'rxjs';
import {pairs} from 'rxjs/operators';

const obj = {rxjs: 'amazing'};

// JS version
// Output: 
// [rxjs,'amazing']
console.log(Object.entries(obj));

// RxJS version
// Output: 
// [rxjs,'amazing']
of(obj).pipe(pairs()).subscribe(console.log);
@BioPhoton BioPhoton changed the title Renaming pairs to entries to provide a more intuitive/JS-aligned API [docs]: Rename/Alias pairs to entries to provide a more intuitive/JS-aligned API Mar 29, 2019
@benlesh
Copy link
Member

benlesh commented Feb 22, 2021

We are deprecating this function and removing it. People can get this by just: from(Object.entries(obj)).

@benlesh benlesh closed this as completed Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants