Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window pipeable operator conflict with global window? #3788

Closed
xp44mm opened this issue Jun 5, 2018 · 6 comments
Closed

window pipeable operator conflict with global window? #3788

xp44mm opened this issue Jun 5, 2018 · 6 comments

Comments

@xp44mm
Copy link
Contributor

xp44mm commented Jun 5, 2018

Bug Report

export { window } from '../internal/operators/window';

as title's speak. at least has some of risk. some editor treat window as a keyword and highlight red color.

@benlesh
Copy link
Member

benlesh commented Jun 5, 2018

Yeah, we'll probably need to come up with a better name.

Thanks for this report, I'm surprised we didn't think of it.

Suggested Workaround

import { window as someOtherName } from 'rxjs/operators';

@xp44mm
Copy link
Contributor Author

xp44mm commented Jun 15, 2018

seem the of is keyword also?

@cartant
Copy link
Collaborator

cartant commented Jun 15, 2018

@xp44mm of isn't a keyword. This is valid JavaScript:

let of = true;

See also #3747.

@xp44mm
Copy link
Contributor Author

xp44mm commented Jun 15, 2018

thank you! some body has found it. i like just, which is been used in the book "fp in javascript".

@xp44mm
Copy link
Contributor Author

xp44mm commented Jun 15, 2018

the window maybe rename to windowed, witch i have seen in some libraries.

@benlesh
Copy link
Member

benlesh commented Aug 20, 2020

Closing in favor of #5296

@benlesh benlesh closed this as completed Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants