Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test scheduler interface improvement #3231

Closed
kwonoj opened this issue Jan 18, 2018 · 1 comment
Closed

Test scheduler interface improvement #3231

kwonoj opened this issue Jan 18, 2018 · 1 comment

Comments

@kwonoj
Copy link
Member

kwonoj commented Jan 18, 2018

I'm writing it as an issue based on discussions we had on core meeting -

Testscheduler included in core is working as expected, but also lacks of some ergonomics around setups and assertions - reason there are couple of variant for 3rd party assertion suite out there. I'd like to self-advertise to my own implementation to adapt into current schedules, which satisfies most of complaints around current testscheduler:

  • frametime adjustment (1 by default, customizable)
  • test framework agnostic
  • long-timeframe support via extended marble syntax
  • fine-grained time travelling (advanceTo interface as similar v4)
  • visual friendly assertion helper function

It could be either make pkg itself as upstream core (once we have monorepo) or either cherrypicking necessary implementation only, or something else - notable thing is core (or separate monorepo-pkg from core) provides de-facto OOTO solution for testing to anyone can easily use.

My current implementation is available at https://github.com/kwonoj/rx-sandbox currently.

/cc @benlesh
(and also @jayphelps , heard you are looking for something similar? not sure but pinging)

@kwonoj
Copy link
Member Author

kwonoj commented May 23, 2018

afaik v6 have ongoing discussions for new test scheduler interface, but it has some core differences with proposed changes here. It'll be tracked separately.

@kwonoj kwonoj closed this as completed May 23, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant