Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate @reactivex/rxjs? #2916

Closed
benlesh opened this issue Oct 6, 2017 · 8 comments
Closed

Eliminate @reactivex/rxjs? #2916

benlesh opened this issue Oct 6, 2017 · 8 comments
Labels
AGENDA ITEM Flagged for discussion at core team meetings

Comments

@benlesh
Copy link
Member

benlesh commented Oct 6, 2017

Currently we release two packages:

  • @reactivex/rxjs
  • rxjs

Right now, the vast, vast majority of users are using rxjs, not @reactivex/rxjs. The major difference between the two used to be that the @reactivex/rxjs one had more builds in it and the original source... however as of 5.5, we have all module build styles in rxjs to support bundlers, and we have the src to support source maps. So they're effectively not that much different anymore.

Should we deprecate @reactivex/rxjs in favor of rxjs?

@kwonoj
Copy link
Member

kwonoj commented Oct 6, 2017

do not forget we have rxjs-es too: #2218

I'm voting to deprecate except main one.

@cartant
Copy link
Collaborator

cartant commented Oct 6, 2017

This is kinda related to #2913. That issue mentions package size as a motivator. Something to consider is that if you are going in the direction of multiple, related packages, having them all under the @reactivex scope might have some advantages.

@rgbkrk
Copy link
Contributor

rgbkrk commented Oct 6, 2017

With all the build styles available in the rxjs name, I'm in favor of deprecating @reactivex/rxjs. It's what I use today and teach others to use.

@benlesh benlesh changed the title Eliminate @reactivex/rxjs publish in 6.0? Eliminate @reactivex/rxjs? Oct 2, 2019
@benlesh
Copy link
Member Author

benlesh commented Oct 2, 2019

We want to do deprecate @reactivex/rxjs still. We can do that once the publishing/build changes land.

@benlesh
Copy link
Member Author

benlesh commented Oct 2, 2019

cc @kwonoj can you link your build-related PR to this?

@kwonoj
Copy link
Member

kwonoj commented Oct 2, 2019

#5032

@kwonoj
Copy link
Member

kwonoj commented Jan 22, 2021

I'm hoisting this as agenda item to check status quo before closing.

@kwonoj kwonoj added the AGENDA ITEM Flagged for discussion at core team meetings label Jan 22, 2021
@benlesh
Copy link
Member Author

benlesh commented May 5, 2021

Core Team Meeting:

  • We still need to support this for version 6.x.
  • We could change the NPM package README.md for just @reactivex/rxjs to have some big "deprecated" message.
  • Optionally: Add Core-JS post install message to the package, so people stop wanting to use it - @kolodny
  • We can probably just ignore this, as hardly anyone uses it, and there's no real documentation around using it.

@benlesh benlesh closed this as completed May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AGENDA ITEM Flagged for discussion at core team meetings
Projects
None yet
Development

No branches or pull requests

4 participants