Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we update to TypeScript 2.1 or 2.3 for v6 (beta to be released soon)? #2613

Closed
benlesh opened this issue May 24, 2017 · 15 comments
Closed

Comments

@benlesh
Copy link
Member

benlesh commented May 24, 2017

I suspect that there are probably quite a few people stuck on TS 2.1 that wouldn't be able to upgrade to the next major version, but I have no usage statistics to back that up. Since it's a breaking change, and there for in a major version bump, it might not matter to most people, and usually only people that want to be on the bleeding edge are early adopters of new major versions.

I believe Angular is now on TS 2.3, so that might play a factor in the decisions.

Thoughts?

@benlesh
Copy link
Member Author

benlesh commented May 24, 2017

related #2606, #2612

@benlesh
Copy link
Member Author

benlesh commented May 24, 2017

FWIW: I'd like to limit the number of breaking changes between major versions to people don't get destroyed when they try to update. But I think we should increase the velocity at which we release majors as well.

@DanielRosenwasser
Copy link
Contributor

DanielRosenwasser commented May 24, 2017

What are the changes between 2.1 & 2.3 that you're concerned about that make sticking to 2.1 more appealing?

@cport1
Copy link

cport1 commented May 24, 2017

I think most of us are using 2.3.2 already...

@benlesh
Copy link
Member Author

benlesh commented May 24, 2017

What are the changes you're concerned about that make sticking to 2.1 more appealing?

@DanielRosenwasser: it's more of a matter of concern that many people are stuck on TS 2.1 for one reason or another. It's probably unfounded.... this is why I'm asking the community

@hccampos
Copy link

I vote for going with 2.3. Mapped typed, generic defaults and so many other goodies that are hard to live without once you've used them a bit.

@paulbakker
Copy link

If there are no reasons why upgrading > 2.1 is difficult (and I don't think there are), I don't see a reason why RX should stick with an older version.

+1 for 2.3

@DanielRosenwasser
Copy link
Contributor

DanielRosenwasser commented May 24, 2017

If you need, we have our Breaking Changes page. I would say that by and large, you'd be better off taking the latest one since we haven't drastically changed anything.

The biggest "gotchas" will be when you use a newer feature whose declarations aren't supported in older versions of TS (e.g. the non-primitive object type, or mixin classes), but I think those things are easily avoidable. Plus, as you may be hearing here, the community tends to upgrade relatively quickly.

I'd say one thing you may want to do is at least test on 2.4, but build with 2.3. TypeScript 2.4 will have some stricter variance checks which can catch legitimate bugs in declarations and usage, especially with Observables.

@staltz
Copy link
Member

staltz commented May 24, 2017

I'd vote for v2.3, I don't think we'll have significant migration headaches inflicted on users, because our current migration bottleneck is getting users from v4/reactive-extensions to v5/reactivex. Like seriously, this chart is worrisome.

@kwonoj
Copy link
Member

kwonoj commented May 24, 2017

I'm on 2.3 as well, as this is breaking changes I don't see strong reason to stay with 2.1. there are few features we'd like to adapt long time like default generics.

@benlesh
Copy link
Member Author

benlesh commented May 24, 2017

Looks like most voices at Google are saying 2.3 as well...

@david-driscoll
Copy link
Member

👍 to 2.3... we then work on integrating default generics, keyof and mapped types too! :)

@benlesh
Copy link
Member Author

benlesh commented May 25, 2017

I think we're settled on 2.3

closing

@benlesh benlesh closed this as completed May 25, 2017
@rajinder-yadav
Copy link

Infinity and beyond!

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants