Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bikeshedding: AnonymousSubject name #2005

Closed
benlesh opened this issue Oct 4, 2016 · 2 comments
Closed

Bikeshedding: AnonymousSubject name #2005

benlesh opened this issue Oct 4, 2016 · 2 comments

Comments

@benlesh
Copy link
Member

benlesh commented Oct 4, 2016

Related #2004

AnonymousSubject is really used for two things:

  1. As a tool in Subject's lift implementation to have operators return Subjects
  2. So Subject.create can "glue an observer to an observable" to form a subject.

I think that "anonymous" doesn't quite describe what this subject is doing.

Do we have any proposed names? Or is AnonymousSubject okay?

I remember that @trxcllnt had called it the BidiSubject at one point very early on, which was short for BidirectionalSubject.

@mattpodwysocki what are your thoughts?

@benlesh
Copy link
Member Author

benlesh commented Jan 24, 2018

This is long gone now.

@benlesh benlesh closed this as completed Jan 24, 2018
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant