-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marble diagram for Observable.concatMapMaybe
is wrong
#7660
Comments
Yes, we have still a lot of outdated and copy-paste diagrams. No promises when they will be updated. |
Hey can I work on this issue |
Sure. |
but what diagram should i replace with? |
You have to draw it yourself, then post the png here. If you have offline Excel, you could do it in our style: Or use Draw.IO but it's a bit fiddly for this type of diagram work. |
Sorry I don't wanna work on this 👍 |
|
@CHIRANTH-24 - note that it's As for the second part - the diagram maps a single source item (the red circle) to multiple results (the white and red squares). It should be only a single white and a single red square. Same for the green and blue ones. Check the diagram for flatMapMaybe. |
https://reactivex.io/RxJava/3.x/javadoc/io/reactivex/rxjava3/core/Observable.html#concatMapMaybe-io.reactivex.rxjava3.functions.Function-
The diagram says
concatMap
instead ofconcatMapMaybe
and also shows two items being emitted by the mapping function which is impossible in aMaybe
. I guess the diagram was copied fromconcatMap
. :)The text was updated successfully, but these errors were encountered: