Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marble diagram for Observable.concatMapMaybe is wrong #7660

Closed
boris-petrov opened this issue Feb 24, 2024 · 8 comments · Fixed by #7698
Closed

Marble diagram for Observable.concatMapMaybe is wrong #7660

boris-petrov opened this issue Feb 24, 2024 · 8 comments · Fixed by #7698

Comments

@boris-petrov
Copy link

https://reactivex.io/RxJava/3.x/javadoc/io/reactivex/rxjava3/core/Observable.html#concatMapMaybe-io.reactivex.rxjava3.functions.Function-

The diagram says concatMap instead of concatMapMaybe and also shows two items being emitted by the mapping function which is impossible in a Maybe. I guess the diagram was copied from concatMap. :)

@akarnokd
Copy link
Member

Yes, we have still a lot of outdated and copy-paste diagrams.

No promises when they will be updated.

@dhrax21
Copy link

dhrax21 commented Apr 5, 2024

Hey can I work on this issue

@akarnokd
Copy link
Member

akarnokd commented Apr 5, 2024

Sure.

@dhrax21
Copy link

dhrax21 commented Apr 5, 2024

but what diagram should i replace with?

@akarnokd
Copy link
Member

akarnokd commented Apr 5, 2024

You have to draw it yourself, then post the png here.

If you have offline Excel, you could do it in our style:

Or use Draw.IO but it's a bit fiddly for this type of diagram work.

@dhrax21
Copy link

dhrax21 commented Apr 6, 2024

Sorry I don't wanna work on this 👍

@CHIRANTH-24
Copy link

concatMapMayBe
Hello @boris-petrov , I was able to understand the first part. Wanted help for the second.

@boris-petrov
Copy link
Author

@CHIRANTH-24 - note that it's Maybe, not MayBe.

As for the second part - the diagram maps a single source item (the red circle) to multiple results (the white and red squares). It should be only a single white and a single red square. Same for the green and blue ones. Check the diagram for flatMapMaybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants