-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x: Move nullness annotation to use sites of Supplier #7385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.x #7385 +/- ##
============================================
- Coverage 99.56% 99.52% -0.05%
+ Complexity 6781 6780 -1
============================================
Files 751 751
Lines 47482 47482
Branches 6378 6378
============================================
- Hits 47276 47255 -21
- Misses 91 105 +14
- Partials 115 122 +7
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Jan 18, 2022
motobrowning
approved these changes
Jan 20, 2022
This was referenced Mar 22, 2022
Open
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nullability to
Maybe.fromSupplier
andMaybe.fromCallable
to avoid warnings in Kotlin when returning nulls from the callbacks.The previous attempt at fixing it in #7384 turned out to be not correct. Based on the responses in the Kotlin Issue report, the lack of warning was the bug and the approach was incorrect from the typesystem perspective.
Therefore, the workaround is to drop the non-null constraint from the
Supplier
declaration and have them at relevant use sites. (https://youtrack.jetbrains.com/issue/KT-50734#focus=Comments-27-5706908.0-0)There was no need to add
@NonNull
everywhere whereSupplier
is used because such sites were already constrained by@NonNull
in the type variable declaration.Resolves #7376