-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing NonNull on Observable.map #7302
Conversation
I noticed this while testing the upcoming Kotlin 1.5.30-M1 (which has improved support for type-use nullability annotations) https://youtrack.jetbrains.com/issue/KT-47833. This makes `at least match Single, but `Maybe.map` is also missing this. I suspect there are others too.
Codecov Report
@@ Coverage Diff @@
## 3.x #7302 +/- ##
============================================
+ Coverage 99.53% 99.54% +0.01%
+ Complexity 6783 6781 -2
============================================
Files 751 751
Lines 47489 47489
Branches 6378 6378
============================================
+ Hits 47266 47271 +5
+ Misses 102 100 -2
+ Partials 121 118 -3
Continue to review full report at Codecov.
|
FYI, I've sweeped across the code base and clarified the nullability annotations on generic type arguments in #7303. |
I noticed this while testing the upcoming Kotlin 1.5.30-M1 (which has improved support for type-use nullability annotations) https://youtrack.jetbrains.com/issue/KT-47833. This makes at least match
Single
, butMaybe.map
is also missing this. I suspect there are others too.