-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure withCredentials is set after open for IE10 #2332
Ensure withCredentials is set after open for IE10 #2332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ok to me, just quick 1 question -
so any other browser won't regress to set withCredentials
after XHR's opened? (I assume it's yes, just try to ensure it)
I'll leave this opened to get second reviewer's opinion.
I only briefly opened the project in Chrome to check that it was still okay and it seemed fine. Though there may be another browser with an edge case I'm not aware of? Some assistance from another tester would be valuable. |
@kwonoj Sorry, I made this change in a rush whilst at work - Let me know if you need me to update the commit format, etc to get it merged. Happy to make changes if necessary. |
@bluespore It'd be appreciate if you can amend commit message, but also I'm curious about how to test this in general to avoid any possible regressions. |
From what I know after researching it, this change is correct and safe. LGTM |
@Blesh Awesome, thanks for this Ben. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description:
IE10 throws an
InvalidStateError
due towithCredentials
being set beforeopen()
. This seems to be due to the release of IE10 stuck on an older spec as described in this StackOverflow ticketRelated issue (if exists):
None.