Skip to content

No ordered iterable type is exported #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patsissons opened this issue Aug 22, 2017 · 3 comments
Closed

No ordered iterable type is exported #31

patsissons opened this issue Aug 22, 2017 · 3 comments

Comments

@patsissons
Copy link
Contributor

IxJS version: 2.0.1

Code to reproduce: let source: OrderedIterable<number> = Iterable.from([1]).orderBy(x => x)

Expected behavior: No type definition errors on OrderedIterable

Actual behavior: no exported member OrderedIterable<T>

Additional information:

This is useful if we ever need to define an unassigned ordered iterable variable. It's also convenient if we want to re-assign a variable via dynamic chaining (i.e. orderby, if condition thenby).

This ought to be a relatively simple fix. The simple version is to simply export OrderedIterableBaseX as OrderedIterable in the api surface. A slightly more involved fix is to create an actual OrderedIterable interface and export that (though i doubt it provides any benefits over the simple fix).

@patsissons
Copy link
Contributor Author

I'm not sure how strictly important this is as the work-around is relatively simple and the people that may actually make use of this is possibly quite small.

@mattpodwysocki
Copy link
Contributor

@patsissons can you verify now?

@patsissons
Copy link
Contributor Author

I believe that is nearly identical to what I had stubbed in during testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants