Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipe): pipe() should always return IterableX<T> #126

Merged
merged 1 commit into from
Oct 31, 2017
Merged

fix(pipe): pipe() should always return IterableX<T> #126

merged 1 commit into from
Oct 31, 2017

Conversation

tetsuharuohzeki
Copy link
Contributor

pipe()'s signature says it always takes Iterable<T> as the input and returns IterableX<T> as the result. But if operations is zero, it returned the input as the result. It's wrong.

david-driscoll
david-driscoll approved these changes Oct 31, 2017
View reviewed changes
Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. The question is should it always return IterableX (to support prototype extension) or not (then it will just return a new iterable)?

  1. Yes - then 👍 :shipit:
  2. No - fix the signature.

@tetsuharuohzeki
Copy link
Contributor Author

@david-driscoll

Yes. I intend to make pipe() returning IterableX always. This change will sort it with pipe() method on prototype.

@mattpodwysocki mattpodwysocki merged commit d7c0556 into ReactiveX:master Oct 31, 2017
@tetsuharuohzeki tetsuharuohzeki deleted the fix-pipe branch November 1, 2017 00:29
trxcllnt pushed a commit that referenced this pull request Nov 2, 2017
@tetsuharuohzeki @trxcllnt
fix(pipe): pipe() should always return IterableX<T> (#126)
bd0a1b9
mattpodwysocki pushed a commit that referenced this pull request Nov 2, 2017
@greenkeeper @mattpodwysocki
Update typescript to the latest version 🚀 (#125)
6e6bf7f 
* chore(package): update typescript to version 2.6.1

* fix(pipe): pipe() should always return IterableX<T> (#126)

* chore(package): update pre-git to version 3.16.0 (#127)

* chore(package): update conventional-github-releaser to version 2.0.0 (#128)

* chore(package): update lerna to version 2.5.0 (#129)

* build(typescript): fix operator signatures for typescript 2.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-driscoll david-driscoll david-driscoll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tetsuharuohzeki @david-driscoll @mattpodwysocki