Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fromNodeStream): adds fromNodeStream readable #124

Merged
merged 7 commits into from
Nov 2, 2017

Conversation

mattpodwysocki
Copy link
Contributor

Description:

Related issue (if exists):

Closes #114

@mattpodwysocki mattpodwysocki merged commit 952509e into master Nov 2, 2017
@mattpodwysocki mattpodwysocki deleted the feat-fromnodestream branch November 2, 2017 23:21
@felixfbecker
Copy link

felixfbecker commented Nov 19, 2017

How can I use this with process.stdin?

fromReadStream(process.stdin)
src/cli.ts(81,37): error TS2345: Argument of type 'ReadStream' is not assignable to parameter of type 'Readable'.
  Property '_read' is missing in type 'ReadStream'.

@trxcllnt
Copy link
Member

@felixfbecker could this be a tsc/node types version difference? I couldn't replicate the issue you're seeing, but I did submit #161 to change the type to the more permissive NodeJS.ReadableStream type

@felixfbecker
Copy link

Maybe. I am using [email protected] and @types/[email protected]. What did you use to test?

@trxcllnt
Copy link
Member

I also tested with [email protected], but @types/[email protected]. I'll go ahead and merge #161 soon and kick out a new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants