-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System.Reactive (3.1.0) forces dependency on NETStandard.Library #295
Comments
+1 |
I am also running into an issue w/ 3.1.0.0, where the identity continues to be 3.0.0.0? Additionally, it appears the dll in .NETStandard is versioned 3.0.1000.0, and the net45 version is 3.0.0.0. This is not only confusing me greatly, but is confusing my poor tests which are now breaking because of this. 😛 I will rollback until I get more clarity around this. |
cc @onovotny for 👀 |
Two separate issues:
|
Ahhh thank you @onovotny for the explanation! I am using NuGet3 which doesn't generate those redirects, unfortunately (captured in NuGet/Home#3372 please upvote :) ). I will get in the habit of installing a package in an empty class library (NuGetv2) and see if it generates anything there before dropping complaints in a repo. 😄 |
@Mike-EEE For the binding redirects, it should not be NuGet that's doing it...it's done as part of the build now. For older projects, they may not have https://msdn.microsoft.com/en-us/library/2fc472t2(v=vs.110).aspx |
We can fix this for desktop .NET for Ix and Rx. Note that for all other platforms, the full |
Ah @onovotny I have another layer of complexity in my solution that might be causing my problems in this case. That is, I am running PostSharp and it runs in its own AppDomain during build. It also does not yet support NuGet3.0 so it requires specific configuration to work property. After a bunch of trial and error I was able to get everything configured and working properly again. 👍 |
@Mike-EEE @mot256 Can you please try the latest 3.1.1 version from the CI feed (https://dotnet.myget.org/gallery/rx) and confirm it works as expected for you? This should be in We can get this tagged and pushed publically very soon. |
Ah, I didn't see the build number until now, @onovotny. I was able to install 00002, but that doesn't have any assemblies. It is also the only build that is available when I connect to that feed (and when I view it here). Is there another location I should be looking at, perhaps? Or maybe a permissions issue? |
@onovotny Just tried, System.Reactive 3.1.1-build-00002 still pulls the whole .NET Standard with it. I suspect that's because System.Reactive.Interfaces is still NETStandard.Library-only. |
Please look at |
@onovotny Tried |
@krs500 Build |
@onovotny The build |
Great, |
A little late to the party, but I was able to upgrade to 3.1.1 with everything "as configured" and all my tests passed with no problem. So, we are good on my side, too. 👍 |
I am not sure if that is the intention, but we cannot use System.Reactive (3.1.0) in .NET 4.5
There seems to be a dependency on NETStandard.Library.1.6.0 and other .NETCore libraries.
Is there a way we can install 3.1.0 without these dependencies? Or are we stuck with 3.0.0?
The text was updated successfully, but these errors were encountered: