-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use history.createLocation in <StaticRouter> #5722
Conversation
fb3a586
to
f9481bb
Compare
Oh bother, I messed up that conflict fix. |
Do you have contributor commits turned on? I can try and help you out. |
Thanks for the offer, but I think I got it figured out. I had re-fetched the branch, but it was rebased onto a copy of the local master, which seems to behave differently than rebasing against # what I had done
git checkout -b static-history
git pull origin static-history
# what I probably should have done
git fetch origin
git checkout origin/static-history
git checkout -b static-history TMYK Anyways, the build issue still seems to exist, so if you don't get to it, I can probably check it out later. |
Weird. There were no recent changes on master and everything is locked, so the last chance of breakage was whenever the lockfiles changed. |
It looks like the build issues have been sorted out. |
In she goes! |
Hi, thanks for fixing this. Any ideas when this will be released? Currently, I'm having to patch React Router locally in order to apply these changes. |
Anytime between now and the future. I've been waiting on some release tooling from Michael, but he's been busy with a few other projects. |
Currently, there is an inconsistency between the pseudo-history used by the
<StaticRouter>
and the histories created by thehistory
package because thehistory
package creates locations with decoded pathnames, while the pseudo-history does not. This PR updates the<StaticRouter>
to use thecreateLocation
function from thehistory
package to ensure consistent decoding between<StaticRouter>
and the other routers.Fixes #5296. #5359 is also partially fixed by this, but that also includes
matchPath
tests which are outside the scope of this PR.