[3.0] Remove deprecations. #3340

timdorr · 2016-04-18T03:18:27Z

timdorr · 2016-04-18T03:57:29Z

Removing many of the deprecations involves fairly interdependent code, so this will be just one single PR for a bunch (all?) of the deprecations.

taion · 2016-04-18T14:27:54Z

modules/Router.js

-      warning(false, '`Router` no longer defaults the history prop to hash history. Please use the `hashHistory` singleton instead. http://tiny.cc/router-defaulthistory')
-      createHistory = createHashHistory
-    }
+    history = { ...history, ...transitionManager }


Don't need the "routing history" any more. This function shouldn't return history at all.

taion · 2016-04-18T15:09:37Z

@timdorr

Do you mind if we leave this PR open until we've taken everything out, so that we still have access to the PR comments?

BTW, the idea w/history is that, once we deprecate everything, it should only show up as a prop to <Router> (and input to match), and nowhere else – nothing downstream gets a history any more.

timdorr · 2016-04-18T15:11:09Z

Yeah, no rush on this.

taion · 2016-04-18T15:35:46Z

modules/getComponents.js

  } else {
-    nextStateWithLocation = { ...nextState, ...location }
+    getComponent.call(route, nextState, callback)


Nit: this shouldn't be in an else. A number of linting rules prohibit "pointless" else clauses per https://github.com/airbnb/javascript/blob/a9db06e1ddbefe3342a61b649c104420d82ba37d/packages/eslint-config-airbnb/rules/best-practices.js#L39. Just put this outside the if block as in #3348.

Oh, I see what you did – the idea with the !getComponent check above and the reason I just bail out there is because it's intended as a guard clause. Otherwise we should probably invert the order of the branches.

timdorr · 2016-04-18T20:38:25Z

Rebased against next, which was updated against master.

Anything left? I think this is good to go.

taion · 2016-04-18T21:14:24Z

modules/createTransitionManager.js

@@ -226,15 +210,6 @@ export default function createTransitionManager(history, routes) {
        if (history.listenBeforeUnload)
          unlistenBeforeUnload = history.listenBeforeUnload(beforeUnloadHook)
      }
-    } else {
-      if (hooks.indexOf(hook) === -1) {


This is not quite right – RouteHooks[routeID] should actually no longer be an array at all, and this else branch should instead just overwrite the value.

So this whole thing should be something like:

const thereWereNoRouteHooks = !hasAnyProperties(RouteHooks) const routeID = getRouteID(route) RouteHooks[routeID] = hook if (thereWereNoRouteHooks) { // ...

Ah crap, I was racing through this to get back to work. I'll have to look at it tonight.

timdorr · 2016-04-20T04:02:19Z

Fixed up listenBeforeLeavingRoute. Let me know if there's anything else.

I'll want to merge up next and then rebase this before merging.

taion · 2016-04-20T04:06:11Z

https://github.com/reactjs/react-router/blob/d3be55cc6b80506456f3d91e53b52046cb480670/modules/createTransitionManager.js#L104-L107 needs to be updated, something like

const hooks = routes
  .map(route => RouteHooks[getRouteID(route)])
  .filter(hook => hook)

taion · 2016-04-20T04:07:32Z

modules/createTransitionManager.js


-    if (!hooks) {
-      let thereWereNoRouteHooks = !hasAnyProperties(RouteHooks)
+    RouteHooks[routeID] = [ hook ]


No need for the array here at all, unless I'm missing something.

timdorr · 2016-04-20T04:08:21Z

Ah, that's what I was missing!

taion · 2016-04-20T04:40:50Z

modules/createTransitionManager.js

-      return hooks
-    }, [])
+    return routes
+      .map(route => RouteHooks[getRouteID(route)])


Oops, this should probably be getRouteID(route, false), actually. No reason to create route IDs here. The undefined will safely avoid colliding with any actual keys under RouteHooks.

Something that "gets" shouldn't have a side effect by default.

timdorr · 2016-04-21T05:31:13Z

OK, updated next against master and rebased this branch. Should be all good to go.

gaearon · 2016-05-05T00:02:54Z

Sorry if this is unrelated—shouldn’t https://github.com/reactjs/react-router/blob/next/modules/RoutingContext.js also go?

timdorr · 2016-05-05T00:04:21Z

Good catch! Yeah, I'll drop that one too.

timdorr added the deprecation label Apr 18, 2016

timdorr changed the title ~~[3.0] Remove context.history/location and History mixin~~ [3.0] Remove some deprecations. Apr 18, 2016

timdorr force-pushed the remove-context-history-location branch from d76c3a3 to 4d43bf4 Compare April 18, 2016 03:59

timdorr force-pushed the next branch from 55f72cb to 1a73278 Compare April 18, 2016 04:03

timdorr mentioned this pull request Apr 18, 2016

[3.0] Remove deprecated code #3336

Closed

9 tasks

taion reviewed Apr 18, 2016
View reviewed changes

timdorr force-pushed the remove-context-history-location branch from 15016f2 to ee3d058 Compare April 18, 2016 15:05

taion added this to the next-3.0.0 milestone Apr 18, 2016

timdorr mentioned this pull request Apr 18, 2016

Remove getComponent deprecations #3348

Closed

timdorr force-pushed the remove-context-history-location branch from 9aedfec to 0dca89a Compare April 18, 2016 15:32

taion reviewed Apr 18, 2016
View reviewed changes

timdorr force-pushed the remove-context-history-location branch from 5e49a1e to eab6f08 Compare April 18, 2016 20:35

taion reviewed Apr 18, 2016
View reviewed changes

timdorr changed the title ~~[3.0] Remove some deprecations.~~ [3.0] Remove deprecations. Apr 18, 2016

taion reviewed Apr 20, 2016
View reviewed changes

timdorr force-pushed the remove-context-history-location branch from d3be55c to 56b0be0 Compare April 20, 2016 04:08

taion reviewed Apr 20, 2016
View reviewed changes

timdorr force-pushed the next branch from 3739c0e to b3c37a8 Compare April 21, 2016 05:29

timdorr added 12 commits April 21, 2016 01:30

Remove context.history/location and History mixin.

e089426

Remove default hashHistory and v2 compat flag.

ba459e3

Remove mixins.

25499a8

Remove Link deprecated props.

427f51b

Remove getComponent deprecation.

ed407b7

Remove useRoutes

afd2be3

Remove RouterContext.props.history.

36a7aba

Remove isActive/replaceState deprecated args.

d75ca1a

Remove multiple leave hooks.

90690e2

Invert getComponents logic.

1b052d4

Fix listenBeforeLeavingRoute.

42692a0

Invert getRouteID default.

1a5666e

Something that "gets" shouldn't have a side effect by default.

timdorr force-pushed the remove-context-history-location branch from 3a30d28 to 1a5666e Compare April 21, 2016 05:30

taion merged commit da81910 into next Apr 21, 2016

taion deleted the remove-context-history-location branch April 21, 2016 07:22

taion mentioned this pull request May 4, 2016

ActiveState changes don't propagate if any single parent in hierarchy declares shouldComponentUpdate #470

Closed

gaearon mentioned this pull request May 4, 2016

Make <Link> work with static containers #3429

Closed

lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.0] Remove deprecations. #3340

[3.0] Remove deprecations. #3340

timdorr commented Apr 18, 2016

timdorr commented Apr 18, 2016

taion Apr 18, 2016

taion commented Apr 18, 2016

timdorr commented Apr 18, 2016

taion Apr 18, 2016

taion Apr 18, 2016

timdorr commented Apr 18, 2016

taion Apr 18, 2016 •

edited

Loading

timdorr Apr 18, 2016 •

edited by ryanflorence

Loading

timdorr commented Apr 20, 2016

taion commented Apr 20, 2016 •

edited

Loading

taion Apr 20, 2016

timdorr commented Apr 20, 2016

taion Apr 20, 2016

timdorr commented Apr 21, 2016

gaearon commented May 5, 2016

timdorr commented May 5, 2016

[3.0] Remove deprecations. #3340

[3.0] Remove deprecations. #3340

Conversation

timdorr commented Apr 18, 2016

timdorr commented Apr 18, 2016

taion Apr 18, 2016

Choose a reason for hiding this comment

taion commented Apr 18, 2016

timdorr commented Apr 18, 2016

taion Apr 18, 2016

Choose a reason for hiding this comment

taion Apr 18, 2016

Choose a reason for hiding this comment

timdorr commented Apr 18, 2016

taion Apr 18, 2016 • edited Loading

Choose a reason for hiding this comment

timdorr Apr 18, 2016 • edited by ryanflorence Loading

Choose a reason for hiding this comment

timdorr commented Apr 20, 2016

taion commented Apr 20, 2016 • edited Loading

taion Apr 20, 2016

Choose a reason for hiding this comment

timdorr commented Apr 20, 2016

taion Apr 20, 2016

Choose a reason for hiding this comment

timdorr commented Apr 21, 2016

gaearon commented May 5, 2016

timdorr commented May 5, 2016

taion Apr 18, 2016 •

edited

Loading

timdorr Apr 18, 2016 •

edited by ryanflorence

Loading

taion commented Apr 20, 2016 •

edited

Loading