Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition bug #3166

Merged
merged 2 commits into from
Mar 10, 2016
Merged

Transition bug #3166

merged 2 commits into from
Mar 10, 2016

Conversation

ryanflorence
Copy link
Member

/users/123/assignments/456
/users/789/assignments/456

The transition hooks were called on assignments, but not users, now it calls them on both.

If a parent route is left/entered, we should leave and enter all the children regardless of their params. Imagine this exact example when you've got a data loading lib that depends on the leaving/entering routes. You'd see user 123's assignment and not user 789's.

When moving from the first path to the second:

  /parent/123/child/456
  /parent/789/child/456

The route hooks on parent are appropriately
called, but not on the child.
@taion
Copy link
Contributor

taion commented Mar 9, 2016

LGTM

Have you had a chance to look at #3108? Seems like you'd need it for data loading as well to pick up on e.g. query changes.

test is in parent commit
@ryanflorence
Copy link
Member Author

I still don't understand why #3108 matters.

@taion
Copy link
Contributor

taion commented Mar 10, 2016

  • You can't use componentWillReceiveProps if you have multiple components per route
  • What if you have something like /users?group=foo, and want to translate this into a query to e.g. /api/v1/users?group=foo? Then there's a transition to e.g. /users?group=bar.

@ryanflorence
Copy link
Member Author

Let's keep the conversation over there...

ryanflorence added a commit that referenced this pull request Mar 10, 2016
@ryanflorence ryanflorence merged commit 6ea547e into master Mar 10, 2016
@ryanflorence ryanflorence deleted the transition-bug branch March 10, 2016 00:20
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants