Additional warnings added for second points limit in edit assignment form.

Author: krulis-martin

src/components/forms/EditAssignmentForm/EditAssignmentForm.js

@@ -940,25 +940,44 @@ const warn = (
 ) => {
   const warnings = {};
 
-  if (deadlines !== 'single' && !validateDeadline({}, formatMessage, firstDeadline, 'firstDeadline', null))
+  if (deadlines !== 'single' && !validateDeadline({}, formatMessage, firstDeadline, 'firstDeadline', null)) {
     warnings.secondDeadline = (
       <FormattedMessage
         id="app.editAssignmentForm.warnings.chooseFirstDeadlineBeforeSecondDeadline"
         defaultMessage="You must select the date of the first deadline before selecting the date of the second deadline."
       />
     );
+  }
 
-  if (
-    deadlines !== 'single' &&
-    Number.isInteger(maxPointsBeforeSecondDeadline) &&
-    maxPointsBeforeFirstDeadline === maxPointsBeforeSecondDeadline
-  ) {
-    warnings.maxPointsBeforeSecondDeadline = (
-      <FormattedMessage
-        id="app.editAssignmentForm.warnings.pointsAreTheSame"
-        defaultMessage="Both points limits are the same, so there is no need for dual-deadline setup."
-      />
-    );
+  if (deadlines !== 'single' && Number.isInteger(maxPointsBeforeSecondDeadline)) {
+    if (maxPointsBeforeFirstDeadline === maxPointsBeforeSecondDeadline) {
+      warnings.maxPointsBeforeSecondDeadline = (
+        <FormattedMessage
+          id="app.editAssignmentForm.warnings.pointsAreTheSame"
+          defaultMessage="Both points limits are the same, so there is no need for dual-deadline setup."
+        />
+      );
+    } else if (maxPointsBeforeFirstDeadline < maxPointsBeforeSecondDeadline) {
+      warnings.maxPointsBeforeSecondDeadline = (
+        <FormattedMessage
+          id="app.editAssignmentForm.warnings.secondLimitIsGreaterThanFirstLimit"
+          defaultMessage="The limit is greater than the first limit which is quite unusal."
+        />
+      );
+    } else if (maxPointsBeforeSecondDeadline === 0) {
+      warnings.maxPointsBeforeSecondDeadline =
+        deadlines === 'dual' ? (
+          <FormattedMessage
+            id="app.editAssignmentForm.warnings.secondLimitIsZero"
+            defaultMessage="The limit is zero, so there is no need for dual-deadline setup."
+          />
+        ) : (
+          <FormattedMessage
+            id="app.editAssignmentForm.warnings.interpolationGoesToZero"
+            defaultMessage="The limit will reach zero before the second deadline (see the graph for details)."
+          />
+        );
+    }
   }
 
   if (canViewJudgeStdout) {

src/locales/cs.json

@@ -278,7 +278,10 @@
   "app.editAssignmentForm.visibility.visibleFrom": "Bude viditelná od daného data",
   "app.editAssignmentForm.visibleFrom": "Datum zveřejnění:",
   "app.editAssignmentForm.warnings.chooseFirstDeadlineBeforeSecondDeadline": "Před nastavením druhého termínu odevzdání je nutné zvolit první termín.",
+  "app.editAssignmentForm.warnings.interpolationGoesToZero": "Limit dosáhne nuly ještě před druhým deadline (viz graf).",
   "app.editAssignmentForm.warnings.pointsAreTheSame": "Oba bodové limity jsou stejné, takže není důvod používat nastavení se dvěma termíny odevzdání.",
+  "app.editAssignmentForm.warnings.secondLimitIsGreaterThanFirstLimit": "Limit je větší než první limit, což je poněkud neobvyklé.",
+  "app.editAssignmentForm.warnings.secondLimitIsZero": "Limit je nula, takže není důvod používat nastavení se dvěma termíny odevzdání.",
   "app.editAssignmentForm.warninigs.alreadyAssigned": "Úloha je v této skupině již zadaná.",
   "app.editAssignmentForm.warninigs.alreadyAssignedGlobal": "Úloha již byla zadána do některých vybraných skupin. Po potvrzení formuláře bude tedy v některých skupinách úloha zadána vícekrát.",
   "app.editAssignmentForm.warninigs.canViewJudgeLogs": "Povolení zveřejnění logů sudího studentům sebou nese určitá rizika. U jednoduchých úloh může např. dojít k tomu, že studenti využijí tento kanál, aby získali vstupní data a očekávané výstupy jednotlivých testů a vyrobili triviální řešení, které má správné odpovědi přímo v kódu. Používejte tuto volbu uváživě.",

src/locales/en.json

@@ -278,7 +278,10 @@
   "app.editAssignmentForm.visibility.visibleFrom": "Become visible on exact date",
   "app.editAssignmentForm.visibleFrom": "Publish date:",
   "app.editAssignmentForm.warnings.chooseFirstDeadlineBeforeSecondDeadline": "You must select the date of the first deadline before selecting the date of the second deadline.",
+  "app.editAssignmentForm.warnings.interpolationGoesToZero": "The limit will reach zero before the second deadline (see the graph for details).",
   "app.editAssignmentForm.warnings.pointsAreTheSame": "Both points limits are the same, so there is no need for dual-deadline setup.",
+  "app.editAssignmentForm.warnings.secondLimitIsGreaterThanFirstLimit": "The limit is greater than the first limit which is quite unusal.",
+  "app.editAssignmentForm.warnings.secondLimitIsZero": "The limit is zero, so there is no need for dual-deadline setup.",
   "app.editAssignmentForm.warninigs.alreadyAssigned": "The exercise has been already assigned in this group.",
   "app.editAssignmentForm.warninigs.alreadyAssignedGlobal": "The exercise has been already assigned in some of the selected groups. It will be assigned again.",
   "app.editAssignmentForm.warninigs.canViewJudgeLogs": "Allowing the students to see judge logs has its security risks. In case of simple exercises, the students may use this channel to retrieve the test inputs and expected outputs and design a trivial solution which embeds the correct outputs directly into the source code. Use this option wisely.",