Removing group external IDs from tables and edit form since they were deprecated.

Author: krulis-martin

src/components/Groups/helpers/GroupInfoTable.js

@@ -29,7 +29,7 @@ const getDescription = (localizedTexts, locale) => {
 };
 
 const GroupInfoTable = ({
-  group: { externalId, organizational, localizedTexts, public: isPublic = false, privateData },
+  group: { organizational, localizedTexts, public: isPublic = false, privateData },
   isAdmin,
   locale,
 }) => (
@@ -96,20 +96,6 @@ const GroupInfoTable = ({
               </td>
             </tr>
           )}
-          {Boolean(externalId) && (
-            <tr>
-              <th>
-                <FormattedMessage
-                  id="app.groupDetail.externalId"
-                  defaultMessage="External identification of the group"
-                />
-                :
-              </th>
-              <td>
-                <code>{externalId}</code>
-              </td>
-            </tr>
-          )}
 
           {privateData &&
             privateData.bindings &&
@@ -153,7 +139,6 @@ const GroupInfoTable = ({
 
 GroupInfoTable.propTypes = {
   group: PropTypes.shape({
-    externalId: PropTypes.string,
     parentGroupId: PropTypes.string,
     threshold: PropTypes.number,
     public: PropTypes.bool.isRequired,

src/components/forms/EditGroupForm/EditGroupForm.js

@@ -12,7 +12,7 @@ import SubmitButton from '../SubmitButton';
 import LocalizedTextsFormField from '../LocalizedTextsFormField';
 import { RefreshIcon } from '../../icons';
 
-import { TextField, CheckboxField, NumericTextField } from '../Fields';
+import { CheckboxField, NumericTextField } from '../Fields';
 import { getLocalizedTextsInitialValues, validateLocalizedTextsFormData } from '../../../helpers/localizedData.js';
 
 export const EDIT_GROUP_FORM_LOCALIZED_TEXTS_DEFAULT = {
@@ -108,18 +108,7 @@ const EditGroupForm = ({
     <Container fluid>
       {isSuperAdmin && (
         <Row className="align-items-end">
-          <Col lg={6}>
-            <Field
-              name="externalId"
-              tabIndex={10}
-              component={TextField}
-              maxLength={255}
-              required
-              ignoreDirty={createNew}
-              label={<FormattedMessage id="app.createGroup.externalId" defaultMessage="External ID of the group:" />}
-            />
-          </Col>
-          <Col lg={6}>
+          <Col lg={12}>
             <Field
               name="isPublic"
               tabIndex={20}

src/locales/cs.json

@@ -275,7 +275,6 @@
   "app.createExerciseForm.validation.noGroupSelected": "Nebyla vybrána domovská skupina.",
   "app.createGroup.detaining": "Zadržuje studenty",
   "app.createGroup.detaining.explanation": "Studenti nemohou sami opustit skupinu, odebrat je může pouze vedoucí/administrátor skupiny.",
-  "app.createGroup.externalId": "Externí identifikátor skupiny:",
   "app.createGroup.hasThreshold": "Studenti potřebují určitý počet bodů pro splnění kurzu",
   "app.createGroup.hasThreshold.explanation": "Potřebný počet bodů může být specifikován relativně (jako procentuální poměr z maximálního počtu bodů) nebo jako absolutní bodový limit. Pouze jedna z těchto hodnot může být vyplněna.",
   "app.createGroup.isExam": "Zkoušková",
@@ -1057,7 +1056,6 @@
   "app.groupDetail.bindings.genericProvider": "Externí vazby na \"{provider}\"",
   "app.groupDetail.bindings.sis": "Kódy rozvrhových lístků ze SIS UK",
   "app.groupDetail.description": "Popis skupiny",
-  "app.groupDetail.externalId": "Externí identifikace skupiny",
   "app.groupDetail.hasPublicStats": "Studenti smí vidět body ostatních studentů",
   "app.groupDetail.isPublic": "Tuto skupinu vidí každý (a může se do ní přihlásit)",
   "app.groupDetail.loading": "Načítání dat skupiny...",

src/locales/en.json

@@ -275,7 +275,6 @@
   "app.createExerciseForm.validation.noGroupSelected": "No group of residence has been selected.",
   "app.createGroup.detaining": "Detaining",
   "app.createGroup.detaining.explanation": "Students cannot leave the group on their own. Only a group supervisor/admin can remove them.",
-  "app.createGroup.externalId": "External ID of the group:",
   "app.createGroup.hasThreshold": "Students require certain number of points to complete the course",
   "app.createGroup.hasThreshold.explanation": "The required amount of points can be specified relatively (percentage of total sum of points) or as an absolute point limit. Only one of these values should be specified.",
   "app.createGroup.isExam": "Exam",
@@ -1057,7 +1056,6 @@
   "app.groupDetail.bindings.genericProvider": "External binding to \"{provider}\"",
   "app.groupDetail.bindings.sis": "SIS UK scheduling event codes",
   "app.groupDetail.description": "Group Description",
-  "app.groupDetail.externalId": "External identification of the group",
   "app.groupDetail.hasPublicStats": "Students can see progress of other students",
   "app.groupDetail.isPublic": "Everyone can see and join this group",
   "app.groupDetail.loading": "Loading group data...",

src/pages/EditGroup/EditGroup.js

@@ -53,14 +53,8 @@ class EditGroup extends Component {
   }
 
   getInitialValues = lruMemoize(
-    ({
-      localizedTexts,
-      externalId,
-      public: isPublic,
-      privateData: { publicStats, threshold, pointsLimit, detaining },
-    }) => ({
+    ({ localizedTexts, public: isPublic, privateData: { publicStats, threshold, pointsLimit, detaining } }) => ({
       localizedTexts: getLocalizedTextsInitialValues(localizedTexts, EDIT_GROUP_FORM_LOCALIZED_TEXTS_DEFAULT),
-      externalId,
       isPublic,
       publicStats,
       detaining,
@@ -330,20 +324,11 @@ export default withLinks(
       reset: () => dispatch(reset('editGroup')),
       loadAsync: () => dispatch(fetchGroupIfNeeded(groupId)),
       reload: () => dispatch(fetchGroup(groupId)),
-      editGroup: ({
-        localizedTexts,
-        externalId,
-        isPublic,
-        publicStats,
-        detaining,
-        hasThreshold,
-        threshold,
-        pointsLimit,
-      }) =>
+      editGroup: ({ localizedTexts, isPublic, publicStats, detaining, hasThreshold, threshold, pointsLimit }) =>
         dispatch(
           editGroup(groupId, {
             localizedTexts: transformLocalizedTextsFormData(localizedTexts),
-            externalId,
+            externalId: '',
             isPublic,
             publicStats,
             detaining,