Skip to content

Commit 62c8dd6

Browse files
committed
Preventing unexpected actions on solutions' detail page (all solution table dialog).
1 parent 10dfb70 commit 62c8dd6

File tree

1 file changed

+39
-37
lines changed

1 file changed

+39
-37
lines changed

src/components/Assignments/SolutionsTable/SolutionsTableRow.js

Lines changed: 39 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -133,43 +133,45 @@ const SolutionsTableRow = ({
133133

134134
{showActionButtons && (
135135
<td className="text-right valign-middle text-nowrap" rowSpan={splitOnTwoLines ? 2 : 1}>
136-
<TheButtonGroup>
137-
{permissionHints && permissionHints.viewDetail && (
138-
<>
139-
<OptionalTooltipWrapper
140-
tooltip={<FormattedMessage id="generic.detail" defaultMessage="Detail" />}
141-
hide={!compact}
142-
tooltipId={`detail-${id}`}>
143-
<Link to={SOLUTION_DETAIL_URI_FACTORY(assignmentId, id)}>
144-
<Button size="xs" variant="secondary" disabled={selected}>
145-
<DetailIcon gapRight={!compact} />
146-
{!compact && <FormattedMessage id="generic.detail" defaultMessage="Detail" />}
147-
</Button>
148-
</Link>
149-
</OptionalTooltipWrapper>
150-
151-
<OptionalTooltipWrapper
152-
tooltip={<FormattedMessage id="app.navigation.solutionFiles" defaultMessage="Submitted Files" />}
153-
hide={!compact}
154-
tooltipId={`codes-${id}`}>
155-
<Link to={SOLUTION_SOURCE_CODES_URI_FACTORY(assignmentId, id)}>
156-
<Button size="xs" variant="primary" disabled={selected}>
157-
<CodeFileIcon fixedWidth gapRight={!compact} />
158-
{!compact && <FormattedMessage id="generic.files" defaultMessage="Files" />}
159-
</Button>
160-
</Link>
161-
</OptionalTooltipWrapper>
162-
</>
163-
)}
164-
165-
{permissionHints && (permissionHints.setFlag || permissionHints.review) && (
166-
<SolutionActionsContainer id={id} captionAsTooltip={compact} showAllButtons dropdown />
167-
)}
168-
169-
{permissionHints && permissionHints.delete && (
170-
<DeleteSolutionButtonContainer id={id} groupId={groupId} size="xs" captionAsTooltip={compact} />
171-
)}
172-
</TheButtonGroup>
136+
{!selected && (
137+
<TheButtonGroup>
138+
{permissionHints && permissionHints.viewDetail && (
139+
<>
140+
<OptionalTooltipWrapper
141+
tooltip={<FormattedMessage id="generic.detail" defaultMessage="Detail" />}
142+
hide={!compact}
143+
tooltipId={`detail-${id}`}>
144+
<Link to={SOLUTION_DETAIL_URI_FACTORY(assignmentId, id)}>
145+
<Button size="xs" variant="secondary" disabled={selected}>
146+
<DetailIcon gapRight={!compact} />
147+
{!compact && <FormattedMessage id="generic.detail" defaultMessage="Detail" />}
148+
</Button>
149+
</Link>
150+
</OptionalTooltipWrapper>
151+
152+
<OptionalTooltipWrapper
153+
tooltip={<FormattedMessage id="app.navigation.solutionFiles" defaultMessage="Submitted Files" />}
154+
hide={!compact}
155+
tooltipId={`codes-${id}`}>
156+
<Link to={SOLUTION_SOURCE_CODES_URI_FACTORY(assignmentId, id)}>
157+
<Button size="xs" variant="primary" disabled={selected}>
158+
<CodeFileIcon fixedWidth gapRight={!compact} />
159+
{!compact && <FormattedMessage id="generic.files" defaultMessage="Files" />}
160+
</Button>
161+
</Link>
162+
</OptionalTooltipWrapper>
163+
</>
164+
)}
165+
166+
{permissionHints && (permissionHints.setFlag || permissionHints.review) && (
167+
<SolutionActionsContainer id={id} captionAsTooltip={compact} showAllButtons dropdown />
168+
)}
169+
170+
{permissionHints && permissionHints.delete && (
171+
<DeleteSolutionButtonContainer id={id} groupId={groupId} size="xs" captionAsTooltip={compact} />
172+
)}
173+
</TheButtonGroup>
174+
)}
173175
</td>
174176
)}
175177
</tr>

0 commit comments

Comments
 (0)